From e737dfd1051ecb969da2ee4e9cb456a10a6ba88a Mon Sep 17 00:00:00 2001 From: Tomi Ollila Date: Wed, 28 Aug 2013 20:31:51 +0300 Subject: [PATCH] Re: [PATCH] emacs: bugfix notmuch-mua-reply when signature is present --- 08/07217bb0bb2693fcd70d0ba62b3372594b3113 | 97 +++++++++++++++++++++++ 1 file changed, 97 insertions(+) create mode 100644 08/07217bb0bb2693fcd70d0ba62b3372594b3113 diff --git a/08/07217bb0bb2693fcd70d0ba62b3372594b3113 b/08/07217bb0bb2693fcd70d0ba62b3372594b3113 new file mode 100644 index 000000000..969f2a2f2 --- /dev/null +++ b/08/07217bb0bb2693fcd70d0ba62b3372594b3113 @@ -0,0 +1,97 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 9ED43431FC2 + for ; Wed, 28 Aug 2013 10:32:08 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id Rw1oACyEY-Xy for ; + Wed, 28 Aug 2013 10:32:00 -0700 (PDT) +Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) + by olra.theworths.org (Postfix) with ESMTP id 8C6EC431FBC + for ; Wed, 28 Aug 2013 10:32:00 -0700 (PDT) +Received: from guru.guru-group.fi (localhost [IPv6:::1]) + by guru.guru-group.fi (Postfix) with ESMTP id 5FB3F100030; + Wed, 28 Aug 2013 20:31:51 +0300 (EEST) +From: Tomi Ollila +To: Geoffrey Ferrari , + notmuch@notmuchmail.org +Subject: Re: [PATCH] emacs: bugfix notmuch-mua-reply when signature is present +In-Reply-To: + <1375961732-14327-1-git-send-email-geoffrey.ferrari@oriel.oxon.org> +References: + <1375961732-14327-1-git-send-email-geoffrey.ferrari@oriel.oxon.org> +User-Agent: Notmuch/0.16+42~g938dae6 (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-unknown-linux-gnu) +X-Face: HhBM'cA~ +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Wed, 28 Aug 2013 17:32:08 -0000 + +On Thu, Aug 08 2013, Geoffrey Ferrari wrote: + +> From: "Geoffrey H. Ferrari" +> +> When composing a reply, notmuch-mua-reply tries to be smart and cite +> the original message by inserting it before the user signature, if +> one is present. However, the existing method of backward searching +> from the end of the buffer to find the signature separator and then +> moving one line up results in the original message being cited in +> the message headers. That's because at this point the message looks +> like this (with | representing point after searching for the +> signature separator): +> +> From: xxx +> To: xxx +> Subject: xxx +> --text follows this line-- +> |-- +> My fancy signature + +Now that I tested, (with ~/.signature), composing new mail starts with + +--8<---8<---8<---8<---8<---8<---8<---8<---8<- +From: Tomi Ollila +To: +Subject: +Fcc: /home/too/mail/mails/sent +--text follows this line-- + +-- +signature +--8<---8<---8<---8<---8<---8<---8<---8<---8<- + +Notice the empty line between '--text follows this line--' and '--' + +In your example, the signature block is -- for some reason -- +inserted without the empty line. + +> With this patch, a newline is opened instead, so that the orignal +> message is cited above the signature but still in the message text. +> --- + + +Tomi -- 2.26.2