From e6e64bcdaa5e7a9a12f85e1d2a2fe76cb703dc50 Mon Sep 17 00:00:00 2001 From: "https://id.koumbit.net/anarcat" Date: Sat, 3 Mar 2012 00:23:08 -0400 Subject: [PATCH] fixup an implementation of the toggleable diff --- ...provide_inline_diffs_in_recentchanges.mdwn | 34 +++++++++++++++++++ 1 file changed, 34 insertions(+) diff --git a/doc/todo/provide_inline_diffs_in_recentchanges.mdwn b/doc/todo/provide_inline_diffs_in_recentchanges.mdwn index fe7eb1014..457b7ccb3 100644 --- a/doc/todo/provide_inline_diffs_in_recentchanges.mdwn +++ b/doc/todo/provide_inline_diffs_in_recentchanges.mdwn @@ -26,4 +26,38 @@ It would rock if I could view diffs from the web without going via feeds. I envi > > > > I am looking for guidance on how to improve and fix this now. --[[anarcat]] 2011-10-11 +> > Here is a better implementation: +> > [[!format txt """ +diff -u change.tmpl.orig change.tmpl +--- change.tmpl.orig 2012-03-02 23:00:36.706271573 -0500 ++++ change.tmpl 2012-03-02 23:15:56.083573086 -0500 +@@ -28,6 +28,9 @@ + +
+ ++ ++[[diff|wikiicons/diff.png]] ++ + [[revert|wikiicons/revert.png]] + + +@@ -39,7 +42,7 @@ + + + +-
++
+ 
+ 
+
+"""]] +> > +> > Unfortunately it has some issues: +> > +> > 1. it assumes the toggle.js code is loaded somehow +> > 2. if the toggle code isn't loaded the diffs are displayed (which is arguably better than showing nothing since we ship the diff to the UA anyways...) +> > 3. it will show only if there's a revert URL, which is backwards, but otherwise the display is weird, with each button on its own line +> > 4. if the diffurl parameter is set in the template, we'd actually see two sets of glasses, which is silly. +> > +> > -- [[anarcat]] 2012-03-11 [[!tag wishlist]] -- 2.26.2