From e6a80358a8c165ecca3bc6ac76e09d67377ef1b1 Mon Sep 17 00:00:00 2001 From: Jani Nikula Date: Sun, 2 Feb 2014 15:03:52 +0200 Subject: [PATCH] Re: [PATCH v2 0/7] lib: replace the message header parser with gmime --- b9/050038e05901390e2bb9e6bd110a288dbd5025 | 102 ++++++++++++++++++++++ 1 file changed, 102 insertions(+) create mode 100644 b9/050038e05901390e2bb9e6bd110a288dbd5025 diff --git a/b9/050038e05901390e2bb9e6bd110a288dbd5025 b/b9/050038e05901390e2bb9e6bd110a288dbd5025 new file mode 100644 index 000000000..473bc8809 --- /dev/null +++ b/b9/050038e05901390e2bb9e6bd110a288dbd5025 @@ -0,0 +1,102 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 12375431FD5 + for ; Sun, 2 Feb 2014 05:04:09 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id wRmijV3GcbAQ for ; + Sun, 2 Feb 2014 05:04:01 -0800 (PST) +Received: from mail-ee0-f41.google.com (mail-ee0-f41.google.com + [74.125.83.41]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client + certificate requested) by olra.theworths.org (Postfix) with ESMTPS id + 8BE77431FC0 for ; Sun, 2 Feb 2014 05:04:01 -0800 + (PST) +Received: by mail-ee0-f41.google.com with SMTP id e51so1121181eek.28 + for ; Sun, 02 Feb 2014 05:04:00 -0800 (PST) +X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; + d=1e100.net; s=20130820; + h=x-gm-message-state:from:to:subject:in-reply-to:references + :user-agent:date:message-id:mime-version:content-type; + bh=kWDWVtPk2HyOBQyEZ5W6MBnaRRf6M75lxVpXjo4czzs=; + b=ZPnKUS4z1lC0ew+mQPIV0dkrwRgZMeY9Wr0YG7NfZCPXK8k5oipPwOCWaRp4KTckaw + +PUKr/sQk0CVi/S9zNKZl2/WLuLoc3slexyjITfmj9RoF+ReTv5Byf1Y0jPNVjnJlg9/ + MPJmmmu5ySJun160CkBjeBBmhqtVJU9PMJSYzGMxO4J8gdarTb12Baq3O9ZgigmNBqdj + K+Z0729EFhrXZxnMECr6p2v2ElD//CVpImq6PNNmU53Hdtm2uPLy6J0ccXX6q3ItfSZl + T8YLtw3+gg+kC52O1e8KBUfQ6ur5ka9SgzNwPgjrLha0KftX3Y6qWekH11PH5uiL0EQ9 + LDyg== +X-Gm-Message-State: + ALoCoQm5pXGmraZ+Z/9Nsou/u0AIXuroVF2tNxoM7HUoHLP+VIn4z+lw8ufGpp/04bc4gmhDNMUg +X-Received: by 10.14.101.5 with SMTP id a5mr1535202eeg.63.1391346240457; + Sun, 02 Feb 2014 05:04:00 -0800 (PST) +Received: from localhost (dsl-hkibrasgw2-58c36f-91.dhcp.inet.fi. + [88.195.111.91]) by mx.google.com with ESMTPSA id + z49sm61810033eeo.10.2014.02.02.05.03.58 for + (version=TLSv1.2 cipher=RC4-SHA bits=128/128); + Sun, 02 Feb 2014 05:03:59 -0800 (PST) +From: Jani Nikula +To: David Bremner , notmuch@notmuchmail.org +Subject: Re: [PATCH v2 0/7] lib: replace the message header parser with gmime +In-Reply-To: <87ob3di0md.fsf@zancas.localnet> +References: + <87ob3di0md.fsf@zancas.localnet> +User-Agent: Notmuch/0.17+44~ge3b4cd9 (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-pc-linux-gnu) +Date: Sun, 02 Feb 2014 15:03:52 +0200 +Message-ID: <871tzly8cn.fsf@nikula.org> +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sun, 02 Feb 2014 13:04:09 -0000 + +On Wed, 15 Jan 2014, David Bremner wrote: +> Jani Nikula writes: +> +>> This is v2 of id:cover.1381948853.git.jani@nikula.org with more polish. +>> +>> Patches 1-4 do prep work to fix some of the differences in the parsers +>> in advance. Arguably they are not that bad regardless of the parser +>> change. +>> +>> Patches 5-6 actually make the change. Having two patches is a somewhat +>> artificial division, but perhaps makes it easier to review. +>> +> +> I had a quick look at these changes, and nothing jumped out at me. I'd +> appreciate a second pair of eyes on them. + +Anyone? + +Patches 1-4 are pretty straightforward prep work, IMHO useful on their +own too. It would help just to get them reviewed and merged first. + +BR, +Jani. + + +> +> I ran the performance suite, and there is only one message (in version +> 0.4 of the corpus) newly classified as non-mail. Of course I did clean +> up the corpus a bunch from 0.3 to 0.4. I didn't see any shocking changes +> in performance before and after the patches. I only had patience enough +> to run twice in both cases. +> +> d -- 2.26.2