From e42a05f75c9ff5d10d0b8f6784fc244873818a99 Mon Sep 17 00:00:00 2001 From: Stephen Boyd Date: Thu, 19 Nov 2009 11:44:46 -0800 Subject: [PATCH] gitweb.js: fix null object exception in initials calculation Currently handleLine() assumes that a commit author name will always start with a capital letter. It's possible that the author name is user@example.com and therefore calling a match() on the name will fail to return any matches. Subsequently joining these matches will cause an exception. Fix by checking that we have a match before trying to join the results into a set of initials for the author. Signed-off-by: Stephen Boyd Acked-by: Jakub Narebski Signed-off-by: Junio C Hamano --- gitweb/gitweb.js | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/gitweb/gitweb.js b/gitweb/gitweb.js index 91b766e33..f1ba9ae52 100644 --- a/gitweb/gitweb.js +++ b/gitweb/gitweb.js @@ -566,8 +566,11 @@ function handleLine(commit, group) { if (group.numlines >= 2) { var fragment = document.createDocumentFragment(); var br = document.createElement("br"); - var text = document.createTextNode( - commit.author.match(/\b([A-Z])\B/g).join('')); + var match = commit.author.match(/\b([A-Z])\B/g); + if (match) { + var text = document.createTextNode( + match.join('')); + } if (br && text) { var elem = fragment || td_sha1; elem.appendChild(br); -- 2.26.2