From e154edcde40deba0879341786bba767cb2f67540 Mon Sep 17 00:00:00 2001 From: David Bremner Date: Thu, 16 Jan 2014 10:19:32 +2000 Subject: [PATCH] Re: [PATCH 2/2] lib: introduce notmuch_database_new for initializing a database handle --- e1/9dc3fe60aab87eeff3f60789cbec74b0441c23 | 76 +++++++++++++++++++++++ 1 file changed, 76 insertions(+) create mode 100644 e1/9dc3fe60aab87eeff3f60789cbec74b0441c23 diff --git a/e1/9dc3fe60aab87eeff3f60789cbec74b0441c23 b/e1/9dc3fe60aab87eeff3f60789cbec74b0441c23 new file mode 100644 index 000000000..7eaf6da7d --- /dev/null +++ b/e1/9dc3fe60aab87eeff3f60789cbec74b0441c23 @@ -0,0 +1,76 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 214CF431FAF + for ; Wed, 15 Jan 2014 06:19:49 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id gagBYfgwraLh for ; + Wed, 15 Jan 2014 06:19:41 -0800 (PST) +Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155]) + (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 9ACD3431FBD + for ; Wed, 15 Jan 2014 06:19:41 -0800 (PST) +Received: from remotemail by yantan.tethera.net with local (Exim 4.80) + (envelope-from ) + id 1W3RJg-00069k-KK; Wed, 15 Jan 2014 10:19:36 -0400 +Received: (nullmailer pid 24799 invoked by uid 1000); Wed, 15 Jan 2014 + 14:19:32 -0000 +From: David Bremner +To: Jani Nikula , Austin Clements +Subject: Re: [PATCH 2/2] lib: introduce notmuch_database_new for initializing + a database handle +In-Reply-To: <87a9eyk8ap.fsf@zancas.localnet> +References: + + <20131204231113.GD8854@mit.edu> <87mwkf40x5.fsf@nikula.org> + <87a9eyk8ap.fsf@zancas.localnet> +User-Agent: Notmuch/0.17+30~g50677dd (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-pc-linux-gnu) +Date: Wed, 15 Jan 2014 10:19:32 -0400 +Message-ID: <87r489iayz.fsf@zancas.localnet> +MIME-Version: 1.0 +Content-Type: text/plain +Cc: notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Wed, 15 Jan 2014 14:19:49 -0000 + +David Bremner writes: + +> I'm not sure if this is also a dead end, but I was trying to sketch out +> an api that returned something more detailed as status and came up with +> the following. The general idea is to replace notmuch_status_t with a +> pointer to struct. This will require pretty noisy source changes, +> unless we're comfortable with using NULL pointer to indicate success. +> In either case we'd rename the existing enum to something like +> notmuch_status_code_t. +> +> /* pseudo-C follows */ +> +> typedef struct notmuch_status_struct * notmuch_status_t; +> + +A less API disruptive change would be to continue returning codes, but +provide functions to interrogate the main types (database, message, etc) +for "last-error". We'd still need to special case database_(open|create) + +d -- 2.26.2