From e133e85b2feb47c0d86d22c7a132a997b8459e08 Mon Sep 17 00:00:00 2001 From: Mark Walters Date: Sun, 16 Mar 2014 14:16:50 +0000 Subject: [PATCH] Re: [PATCH] make http links into buttons --- 89/cfb3ab45d6ae62cdb9fe07ac77b22a6f7dc9d0 | 107 ++++++++++++++++++++++ 1 file changed, 107 insertions(+) create mode 100644 89/cfb3ab45d6ae62cdb9fe07ac77b22a6f7dc9d0 diff --git a/89/cfb3ab45d6ae62cdb9fe07ac77b22a6f7dc9d0 b/89/cfb3ab45d6ae62cdb9fe07ac77b22a6f7dc9d0 new file mode 100644 index 000000000..35125026f --- /dev/null +++ b/89/cfb3ab45d6ae62cdb9fe07ac77b22a6f7dc9d0 @@ -0,0 +1,107 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 13E96429E48 + for ; Sun, 16 Mar 2014 07:17:05 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -1.098 +X-Spam-Level: +X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5 + tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001, + NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id 53Z+2Y1H8ti2 for ; + Sun, 16 Mar 2014 07:16:57 -0700 (PDT) +Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6]) + (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 77593429E26 + for ; Sun, 16 Mar 2014 07:16:57 -0700 (PDT) +Received: from smtp.qmul.ac.uk ([138.37.6.40]) + by mail2.qmul.ac.uk with esmtp (Exim 4.71) + (envelope-from ) + id 1WPBrv-0003n9-NN; Sun, 16 Mar 2014 14:16:52 +0000 +Received: from 93-97-24-31.zone5.bethere.co.uk ([93.97.24.31] helo=localhost) + by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.71) + (envelope-from ) + id 1WPBrv-0007GW-CS; Sun, 16 Mar 2014 14:16:51 +0000 +From: Mark Walters +To: David Bremner , notmuch@notmuchmail.org +Subject: Re: [PATCH] make http links into buttons +In-Reply-To: <87mwisqhx7.fsf@zancas.localnet> +References: <1377240695-825-1-git-send-email-markwalters1009@gmail.com> + <87mwisqhx7.fsf@zancas.localnet> +User-Agent: Notmuch/0.15.2+615~g78e3a93 (http://notmuchmail.org) Emacs/23.4.1 + (x86_64-pc-linux-gnu) +Date: Sun, 16 Mar 2014 14:16:50 +0000 +Message-ID: <8738iitei5.fsf@qmul.ac.uk> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-Sender-Host-Address: 93.97.24.31 +X-QM-Geographic: According to ripencc, + this message was delivered by a machine in Britain (UK) (GB). +X-QM-SPAM-Info: Sender has good ham record. :) +X-QM-Body-MD5: 910bba68917ecef217def491d1f2f310 (of first 20000 bytes) +X-SpamAssassin-Score: 0.0 +X-SpamAssassin-SpamBar: / +X-SpamAssassin-Report: The QM spam filters have analysed this message to + determine if it is + spam. We require at least 5.0 points to mark a message as spam. + This message scored 0.0 points. Summary of the scoring: + * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail + provider * (markwalters1009[at]gmail.com) + * -0.0 T_RP_MATCHES_RCVD Envelope sender domain matches handover relay + * domain + * 0.0 AWL AWL: From: address is in the auto white-list +X-QM-Scan-Virus: ClamAV says the message is clean +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sun, 16 Mar 2014 14:17:05 -0000 + + +Since there was a little discussion about this on irc I post it here (with +bremner's permission) so that it doesn't get lost. + +Best wishes + +Mark + +Day changed Mon Jan 20 2014 + +14:28 < mjw1009_> bremner: I am not sure quite what behaviour you were seeing on the link-buttons message (nor quite what you would expect) +14:29 < mjw1009_> (that is the message attached to id:87mwisqhx7.fsf@zancas.localnet) +14:29 < bremner> umm. hangon, I need to re-enable that patch. +14:30 < mjw1009_> before you do can you check it behaves as you expect in master? +14:30 < bremner> well, tabbing doesn't visit the URLs at all in master. so I guess yes? +14:30 < mjw1009_> and you would expect it just to stop at the [text/html] part button? +14:31 < bremner> it bounces between the from address and the text/html button +14:31 < mjw1009_> (I was a little surprised when looking at the code that we linkify the html part at all rather than leaving that to shr or something) +14:32 < mjw1009_> Oh great. that behaves differently in emacs 23 +14:32 < mjw1009_> (on master) +14:32 < bremner> ah. this could be tricky. Do you have access to emacs24? +14:33 < mjw1009_> yes +14:34 < bremner> ok, with the patch in emacs24, I hit tab 3 times, and then it seems stuck at "mathematical_statistical_sciences@nsa.gov" +14:35 < mjw1009_> Ok now I can reproduce some odd behaviour. It works much more as expected in emacs23 +14:36 < mjw1009_> I don't know why it is cycling in the normal case on emacs24. on normal message tab on emacs23 stops at the end of the message and signals an error. +14:37 < mjw1009_> But anyway I now know where to look so I can do some experiments. Thanks! +14:37 < bremner> cool. + +20:04 < mjw1009_> does anyone else see the following on emacs24: goto a message with a text/html part(eg id:CAGhLh6F=m_K9QqmwXmakfeyPbCtMriBAr+6FQ7N8seT=r15KmQ@mail.gmail.com ); if you tab thought the message it all behaves correctly, but if you open the text-html part and tab through then the cursor goes from the text-html button to the top of the buffer + +Day changed Tue Jan 21 2014 + +02:03 < bremner> mjw1009_: yeah, I can duplicate that. + -- 2.26.2