From e0dd888a1a82c9e3fea1f0e039bcbef375a722f4 Mon Sep 17 00:00:00 2001 From: Tomi Ollila Date: Wed, 16 Mar 2016 10:54:27 +0200 Subject: [PATCH] Re: [PATCH v1] emacs: Don't insert part header pseudo-buttons during reply by default. --- 03/bb69c5202141479456dcc8aa81e809f982c8df | 93 +++++++++++++++++++++++ 1 file changed, 93 insertions(+) create mode 100644 03/bb69c5202141479456dcc8aa81e809f982c8df diff --git a/03/bb69c5202141479456dcc8aa81e809f982c8df b/03/bb69c5202141479456dcc8aa81e809f982c8df new file mode 100644 index 000000000..87c15d455 --- /dev/null +++ b/03/bb69c5202141479456dcc8aa81e809f982c8df @@ -0,0 +1,93 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by arlo.cworth.org (Postfix) with ESMTP id E4FFE6DE181C + for ; Wed, 16 Mar 2016 01:54:27 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at cworth.org +X-Spam-Flag: NO +X-Spam-Score: 0.63 +X-Spam-Level: +X-Spam-Status: No, score=0.63 tagged_above=-999 required=5 tests=[AWL=-0.022, + SPF_NEUTRAL=0.652] autolearn=disabled +Received: from arlo.cworth.org ([127.0.0.1]) + by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id Du4VEVyGVOFq for ; + Wed, 16 Mar 2016 01:54:25 -0700 (PDT) +Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) + by arlo.cworth.org (Postfix) with ESMTP id DF2ED6DE181A + for ; Wed, 16 Mar 2016 01:54:24 -0700 (PDT) +Received: from guru.guru-group.fi (localhost [IPv6:::1]) + by guru.guru-group.fi (Postfix) with ESMTP id 03D69100063; + Wed, 16 Mar 2016 10:54:28 +0200 (EET) +From: Tomi Ollila +To: David Edmondson , notmuch@notmuchmail.org +Subject: Re: [PATCH v1] emacs: Don't insert part header pseudo-buttons during + reply by default. +In-Reply-To: <1458117593-32586-1-git-send-email-dme@dme.org> +References: <1458117593-32586-1-git-send-email-dme@dme.org> +User-Agent: Notmuch/0.21+86~gd34ae6a (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-unknown-linux-gnu) +X-Face: HhBM'cA~ +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.20 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Wed, 16 Mar 2016 08:54:28 -0000 + +On Wed, Mar 16 2016, David Edmondson wrote: + +> [ text/plain ] +> Based on feedback from users, change the default value of +> `notmuch-mua-reply-insert-header-p-function' to +> `notmuch-show-reply-insert-header-p-never', with the consequence that +> replies will not have part header pseudo-buttons. This more closely +> matches the behaviour before the recent changes to the reply code. +> --- +> emacs/notmuch-mua.el | 2 +- +> 1 file changed, 1 insertion(+), 1 deletion(-) +> +> diff --git a/emacs/notmuch-mua.el b/emacs/notmuch-mua.el +> index fcb3e95..773a000 100644 +> --- a/emacs/notmuch-mua.el +> +++ b/emacs/notmuch-mua.el +> @@ -94,7 +94,7 @@ Note that these functions use `mail-citation-hook' if that is non-nil." +> :group 'notmuch-reply) +> +> (defcustom notmuch-mua-reply-insert-header-p-function +> - 'notmuch-show-reply-insert-header-p-trimmed +> + 'notmuch-show-reply-insert-header-p-never +> "Function to decide which parts get a header when replying. + +LGTM. + +For test robustness, the related change in output of +git show d27d90875dfb1 (, Sat Feb 20 2016): + ++;; For historical reasonse we don't print part headers when replying ++;; in the tests suite ++(setq notmuch-mua-reply-insert-header-p-function +'notmuch-show-reply-insert-header-p-never) + +could also be reverted. + +(another thing that would be so cool: + #'notmuch-show-reply-insert-header-p-never +but perhaps such a thing is to be done in separate patch "globally") + + +Tomi -- 2.26.2