From e0d2d6627640a649d242c9a0da2f703b9646cdf0 Mon Sep 17 00:00:00 2001 From: David Bremner Date: Mon, 12 May 2014 20:29:09 +0900 Subject: [PATCH] Re: [PATCH] lib: Precede all function names in notmuch-private.h with an underscore. --- d4/93e5465466c278d509e16757ab1c65a7c991ed | 78 +++++++++++++++++++++++ 1 file changed, 78 insertions(+) create mode 100644 d4/93e5465466c278d509e16757ab1c65a7c991ed diff --git a/d4/93e5465466c278d509e16757ab1c65a7c991ed b/d4/93e5465466c278d509e16757ab1c65a7c991ed new file mode 100644 index 000000000..aa9af2bf0 --- /dev/null +++ b/d4/93e5465466c278d509e16757ab1c65a7c991ed @@ -0,0 +1,78 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 1C524431FC2 + for ; Mon, 12 May 2014 04:30:59 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id 2Z4MaOXyC9d9 for ; + Mon, 12 May 2014 04:30:51 -0700 (PDT) +Received: from mx.xen14.node3324.gplhost.com (gitolite.debian.net + [87.98.215.224]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 92B5F431FC0 + for ; Mon, 12 May 2014 04:30:51 -0700 (PDT) +Received: from remotemail by mx.xen14.node3324.gplhost.com with local (Exim + 4.72) (envelope-from ) + id 1WjoQI-0007LJ-Bt; Mon, 12 May 2014 11:29:34 +0000 +Received: (nullmailer pid 3745 invoked by uid 1000); Mon, 12 May 2014 + 11:29:09 -0000 +From: David Bremner +To: Charles Celerier , notmuch@notmuchmail.org +Subject: Re: [PATCH] lib: Precede all function names in notmuch-private.h + with an underscore. +In-Reply-To: <87d2fjgtcr.fsf@maritornes.cs.unb.ca> +References: <1399402716-13714-1-git-send-email-cceleri@cs.stanford.edu> + <87d2fjgtcr.fsf@maritornes.cs.unb.ca> +User-Agent: Notmuch/0.18 (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-pc-linux-gnu) +Date: Mon, 12 May 2014 20:29:09 +0900 +Message-ID: <877g5rgrqy.fsf@maritornes.cs.unb.ca> +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Mon, 12 May 2014 11:30:59 -0000 + +David Bremner writes: + +> Charles Celerier writes: +> +>> An underscore should precede every function name in +>> lib/notmuch-private.h. This was not true and was noted by the failure of +>> test T360-symbol-hiding on Mac OS/X. This patch inserts an underscore +>> before each function name in lib/notmuch-private.h where the underscore +>> was missing and renames functions appropriately where they are used. +> +> Originally I thought this was uneccesarily intrusive, but on a second +> look I see that there is only one symbol changed that doesn't start with +> _notmuch, so I guess for consistency it's fine. +> +> I'm thinking about a 0.18.1 point release for build and portability +> fixes; I do think this is a bit too much change for that (especially +> since it doesn't actually fix the symbol hiding test (or more precisely, +> your fix for OS/X breaks the linux test). + +Also, I'd like a less confusing commit message. Do you understand the +situation enough to write one now? In particular it's just a convention +that private symbols should not start with "notmuch", and the actual +hiding happens elsewhere. + +d -- 2.26.2