From dc7958e557a8874f4126d71a5b7afaa0abf7df60 Mon Sep 17 00:00:00 2001 From: Tomi Ollila Date: Tue, 28 Jun 2016 00:16:41 +0300 Subject: [PATCH] Re: [PATCH] doc: forbid further operations on a closed database --- de/73b39f6f487bf7e20001f3e52259c6bea3debb | 74 +++++++++++++++++++++++ 1 file changed, 74 insertions(+) create mode 100644 de/73b39f6f487bf7e20001f3e52259c6bea3debb diff --git a/de/73b39f6f487bf7e20001f3e52259c6bea3debb b/de/73b39f6f487bf7e20001f3e52259c6bea3debb new file mode 100644 index 000000000..bb19007c9 --- /dev/null +++ b/de/73b39f6f487bf7e20001f3e52259c6bea3debb @@ -0,0 +1,74 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by arlo.cworth.org (Postfix) with ESMTP id E735F6DE01BA + for ; Mon, 27 Jun 2016 14:17:32 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at cworth.org +X-Spam-Flag: NO +X-Spam-Score: 0.566 +X-Spam-Level: +X-Spam-Status: No, score=0.566 tagged_above=-999 required=5 tests=[AWL=-0.086, + SPF_NEUTRAL=0.652] autolearn=disabled +Received: from arlo.cworth.org ([127.0.0.1]) + by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id dZwu9rUxloT5 for ; + Mon, 27 Jun 2016 14:17:23 -0700 (PDT) +Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) + by arlo.cworth.org (Postfix) with ESMTP id A43846DE014D + for ; Mon, 27 Jun 2016 14:17:23 -0700 (PDT) +Received: from guru.guru-group.fi (localhost [IPv6:::1]) + by guru.guru-group.fi (Postfix) with ESMTP id 5373E1000E1; + Tue, 28 Jun 2016 00:16:41 +0300 (EEST) +From: Tomi Ollila +To: David Bremner , David Bremner , + notmuch@notmuchmail.org +Subject: Re: [PATCH] doc: forbid further operations on a closed database +In-Reply-To: <1467052720-18041-1-git-send-email-david@tethera.net> +References: <87porqxmm5.fsf@tesseract.cs.unb.ca> + <1467052720-18041-1-git-send-email-david@tethera.net> +User-Agent: Notmuch/0.22+54~gf8fd4ff (https://notmuchmail.org) Emacs/24.5.1 + (x86_64-unknown-linux-gnu) +X-Face: HhBM'cA~ +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.20 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Mon, 27 Jun 2016 21:17:33 -0000 + +On Mon, Jun 27 2016, David Bremner wrote: + +> We could add many null pointer checks, but currently I don't see a use +> case that justifies it. +> --- +> lib/notmuch.h | 4 +++- +> 1 file changed, 3 insertions(+), 1 deletion(-) +> +> diff --git a/lib/notmuch.h b/lib/notmuch.h +> index d4a97cb..2faa146 100644 +> --- a/lib/notmuch.h +> +++ b/lib/notmuch.h +> @@ -332,7 +332,9 @@ notmuch_database_status_string (const notmuch_database_t *notmuch); +> * functions on objects derived from this database may either behave +> * as if the database had not been closed (e.g., if the required data +> * has been cached) or may fail with a +> - * NOTMUCH_STATUS_XAPIAN_EXCEPTION. +> + * NOTMUCH_STATUS_XAPIAN_EXCEPTION. The only further operation +> + * permitted on the database itself is to call +> + * notmuch_database_destroy. + +LGTM -- 2.26.2