From dc41d448a025f54b789ce1229ea9bc83c1283212 Mon Sep 17 00:00:00 2001 From: David Bremner Date: Sat, 19 Sep 2015 09:03:20 +2100 Subject: [PATCH] Re: [bug] notmuch requires Content-Disposition mime header value to be lower case --- e6/ccc271992b4a79e86e88d236d6adbdd2fc9551 | 91 +++++++++++++++++++++++ 1 file changed, 91 insertions(+) create mode 100644 e6/ccc271992b4a79e86e88d236d6adbdd2fc9551 diff --git a/e6/ccc271992b4a79e86e88d236d6adbdd2fc9551 b/e6/ccc271992b4a79e86e88d236d6adbdd2fc9551 new file mode 100644 index 000000000..8a2509f52 --- /dev/null +++ b/e6/ccc271992b4a79e86e88d236d6adbdd2fc9551 @@ -0,0 +1,91 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by arlo.cworth.org (Postfix) with ESMTP id E910F6DE01F7 + for ; Fri, 18 Sep 2015 05:04:40 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at cworth.org +X-Spam-Flag: NO +X-Spam-Score: 0.114 +X-Spam-Level: +X-Spam-Status: No, score=0.114 tagged_above=-999 required=5 tests=[AWL=0.114] + autolearn=disabled +Received: from arlo.cworth.org ([127.0.0.1]) + by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id OV6ppnVJwvaF for ; + Fri, 18 Sep 2015 05:04:39 -0700 (PDT) +Received: from gitolite.debian.net (gitolite.debian.net [87.98.215.224]) + by arlo.cworth.org (Postfix) with ESMTPS id E95E96DE00DE + for ; Fri, 18 Sep 2015 05:04:38 -0700 (PDT) +Received: from remotemail by gitolite.debian.net with local (Exim 4.80) + (envelope-from ) + id 1ZcuOC-0001FU-V0; Fri, 18 Sep 2015 12:03:40 +0000 +Received: (nullmailer pid 9821 invoked by uid 1000); Fri, 18 Sep 2015 + 12:03:20 -0000 +From: David Bremner +To: Johannes Schauer , notmuch@notmuchmail.org +Subject: Re: [bug] notmuch requires Content-Disposition mime header value to + be lower case +In-Reply-To: <20150917083956.1941.35098@localhost> +References: <20150917070056.1941.94846@localhost> + <20150917083612.1941.22480@localhost> <20150917083956.1941.35098@localhost> +User-Agent: Notmuch/0.20.2+73~gd432116 (http://notmuchmail.org) Emacs/24.5.1 + (x86_64-pc-linux-gnu) +Date: Fri, 18 Sep 2015 09:03:20 -0300 +Message-ID: <87pp1grl2v.fsf@maritornes.cs.unb.ca> +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.18 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Fri, 18 Sep 2015 12:04:41 -0000 + +Johannes Schauer writes: + + +> Funnily though there seem to be some weird newline differences that I cannot +> explain, so I left them for somebody else to fix. +> + +Looking at the files (.EXPECTED and .OUTPUT) in test/tmp.T190-multipart, +there's more than whitespace changes. Some things that used to marked +"attachment" in the output are now marked "part". + +> diff --git a/test/T190-multipart.sh b/test/T190-multipart.sh +> index 7c4c9f7..f16cc90 100755 +> --- a/test/T190-multipart.sh +> +++ b/test/T190-multipart.sh +> @@ -48,7 +48,7 @@ cat embedded_message >> ${MAIL_DIR}/multipart +> cat <> ${MAIL_DIR}/multipart +> +> --=-=-= +> -Content-Disposition: attachment; filename=attachment +> +Content-Disposition: ATTACHMENT; FILENAME=attachment +> +> This is a text attachment. +> +> @@ -487,7 +487,7 @@ This is an embedded message, with a multipart/alternative part. +> --==-=-==-- +> +> --=-=-= +> -Content-Disposition: attachment; filename=attachment +> +Content-Disposition: ATTACHMENT; FILENAME=attachment +> +> This is a text attachment. +> + +I'd recommend making your own new test, rather than modifying existing +ones to test multiple things. I'd also recommend using json / sexp +output for your tests, since the ad-hoc text format is kindof +semi-deprecated. + +d -- 2.26.2