From dbe58db511929acf1dc398e0e51509b51480cb8d Mon Sep 17 00:00:00 2001 From: Mark Walters Date: Sat, 9 Apr 2016 23:40:58 +0100 Subject: [PATCH] Re: Breaking a really long thread --- 1a/2e354c0c65215b1e26ce48b720acee0ed1de7c | 131 ++++++++++++++++++++++ 1 file changed, 131 insertions(+) create mode 100644 1a/2e354c0c65215b1e26ce48b720acee0ed1de7c diff --git a/1a/2e354c0c65215b1e26ce48b720acee0ed1de7c b/1a/2e354c0c65215b1e26ce48b720acee0ed1de7c new file mode 100644 index 000000000..2b68700e8 --- /dev/null +++ b/1a/2e354c0c65215b1e26ce48b720acee0ed1de7c @@ -0,0 +1,131 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by arlo.cworth.org (Postfix) with ESMTP id 51C456DE02BF + for ; Sat, 9 Apr 2016 15:41:12 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at cworth.org +X-Spam-Flag: NO +X-Spam-Score: -0.775 +X-Spam-Level: +X-Spam-Status: No, score=-0.775 tagged_above=-999 required=5 + tests=[AWL=-0.205, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, + DKIM_VALID_AU=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, + FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01, + RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001] autolearn=disabled +Received: from arlo.cworth.org ([127.0.0.1]) + by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id 4K29gO3qiJKj for ; + Sat, 9 Apr 2016 15:41:03 -0700 (PDT) +Received: from mail-wm0-f67.google.com (mail-wm0-f67.google.com + [74.125.82.67]) by arlo.cworth.org (Postfix) with ESMTPS id 24B726DE00BD for + ; Sat, 9 Apr 2016 15:41:03 -0700 (PDT) +Received: by mail-wm0-f67.google.com with SMTP id l6so12725626wml.3 + for ; Sat, 09 Apr 2016 15:41:03 -0700 (PDT) +DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; + h=from:to:subject:in-reply-to:references:user-agent:date:message-id + :mime-version; bh=1AG3MCU9jLq3m+T3TNRxafwXwJV4jPp/7TWk95TOM/A=; + b=UiB/XacKO14eNmjtfRamSJpCVuYuy9T4mBVzjk1wcrtzEk49q5PG+A0irSZGvf3T9Z + HfEZ5Yb0koxYWYjC4zTzOHwHkKaLaP0gWxXywXHAEYSUjrKRc0+LXgwVrN8c/WNGFITn + YCeLray70wJG1zEnTxdDChanffumX9m6uhXavgFxJejQllKWeJ6Is7tptZH7JeSQTnHv + jv/qNsscRp6B4WFNZUcJb22fUVFkqMw4s41Qw6de+3oi6Gw2+Lh03zIixdZ056V0I0xP + fFhc+lAuzw9YA+ZW5vxe67UpFSrCZDiwudUFVFeCvRVvZXbzMG3M+qxLZa2XRJ0VgGEU + KK9A== +X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; + d=1e100.net; s=20130820; + h=x-gm-message-state:from:to:subject:in-reply-to:references + :user-agent:date:message-id:mime-version; + bh=1AG3MCU9jLq3m+T3TNRxafwXwJV4jPp/7TWk95TOM/A=; + b=cEBCKAjzqCjWIipjwxeZz+Wp2C5YqUiktbbvZJtrDmXZJ8LX3K7wJKucjHZnGvMSYH + JZnf5JbaOuHcrY7bLwLhvElXj2d/Drdkox8rcr1gBvr//Mh65PEwg6GfDx68KFm7vH0g + TeYZQ+w6AW+l7+kUGDGV5dFl9x6RmsaGEsYrKIItTkbWRePEP6Z78BIcT6/mybX1dTLx + WJXmp3H1ZPtcFqoDiZqWUIHHTZPXCel/XwGUtIUNSRtwv6Sh3/m0GCpd52Z/YRoiCaPy + h+Am81U9Km8BODUoaBPa2dvzOsmmZNIcapOcqUWg59gA4zi4VK+DTZjdUWeVarJU4kIU + GlCg== +X-Gm-Message-State: + AD7BkJJZeBkwCGspadvH7JMprcT3dvl0J/8lZ3kVDM61KgqlcotUbJ4S8zOJRnZQkQ603w== +X-Received: by 10.28.107.195 with SMTP id a64mr10215985wmi.69.1460241661705; + Sat, 09 Apr 2016 15:41:01 -0700 (PDT) +Received: from localhost (188.29.66.211.threembb.co.uk. [188.29.66.211]) + by smtp.gmail.com with ESMTPSA id d1sm5896868wjb.47.2016.04.09.15.40.59 + (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); + Sat, 09 Apr 2016 15:41:01 -0700 (PDT) +From: Mark Walters +To: David Bremner , + Daniel Kahn Gillmor , + David Mazieres expires 2016-07-03 PDT + , + notmuch@notmuchmail.org +Subject: Re: Breaking a really long thread +In-Reply-To: <87fuuu3938.fsf@zancas.localnet> +References: + <87k2kd8r6d.fsf@qmul.ac.uk> <87wpoc7hf8.fsf@ta.scs.stanford.edu> + <8760vrm3jk.fsf@alice.fifthhorseman.net> <87fuuu3938.fsf@zancas.localnet> +User-Agent: Notmuch/0.21+17~g6d0b613 (http://notmuchmail.org) Emacs/24.4.1 + (x86_64-pc-linux-gnu) +Date: Sat, 09 Apr 2016 23:40:58 +0100 +Message-ID: <87bn5ijthh.fsf@qmul.ac.uk> +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.20 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sat, 09 Apr 2016 22:41:12 -0000 + + +Hi + +On Sat, 09 Apr 2016, David Bremner wrote: +> Daniel Kahn Gillmor writes: +> +>> On Tue 2016-04-05 01:28:43 -0400, David Mazieres wrote: +>>> Arguably, I would say either both the In-Reply-To and the References +>>> header should be hidden or neither. Otherwise, what was happening is +>>> that I was deleting the In-Reply-To header as it was the only one I saw, +>>> and figuring that maybe References was adjusted after the fact based on +>>> In-Reply-To. After all, the message buffer doesn't keep track of the +>>> parent message. +>>> +>>> Unless there's a reason that someone would want to alter In-Reply-To +>>> without altering References, it doesn't make sense to show one without +>>> the other. +>> +>> I think i agree with David here, but the fact is that +>> message-hidden-headers is derived directly from emacs (in message.el), +>> and isn't part of notmuch-emacs at all. +>> +>> Are these changes worth addressing upstream? +> +> Possibly. Although changing defaults is usually a cesspit of +> bikeshedding. What would we ask, that upstream add In-Reply-To to +> message-hidden-headers? +> +> Related, showing hidden headers doesn't actually work very well: +> +> http://debbugs.gnu.org/cgi/bugreport.cgi?bug=23252 +> +> I thought briefly about overriding the value in notmuch-message-mode, +> perhaps by having a defcustom for notmuch-message-hidden-headers. + +I think we already have this, except it is called +notmuch-mua-hidden-headers. It defaults to '("^User-Agent:"). + +I think it would be reasonable to add In-Reply-To to this list. + +However, if I read the code correctly, currently we are changing +message-hidden-headers globally which doesn't feel the right thing to +do. Probably we should do something more like you suggest, and do the +overriding just in notmuch-message-mode. + +Best wishes + +Mark -- 2.26.2