From dbac098851b80453c85823beb1ed7ddc458b032a Mon Sep 17 00:00:00 2001 From: David Bremner Date: Sat, 26 Sep 2015 09:25:36 +2100 Subject: [PATCH] Re: [PATCH] test suite: don't consider skipped individual tests as failing --- fe/bbe00b902a63d594281369004a1bb78ddd9720 | 64 +++++++++++++++++++++++ 1 file changed, 64 insertions(+) create mode 100644 fe/bbe00b902a63d594281369004a1bb78ddd9720 diff --git a/fe/bbe00b902a63d594281369004a1bb78ddd9720 b/fe/bbe00b902a63d594281369004a1bb78ddd9720 new file mode 100644 index 000000000..f1525f08e --- /dev/null +++ b/fe/bbe00b902a63d594281369004a1bb78ddd9720 @@ -0,0 +1,64 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by arlo.cworth.org (Postfix) with ESMTP id CD5146DE13AB + for ; Fri, 25 Sep 2015 05:26:57 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at cworth.org +X-Spam-Flag: NO +X-Spam-Score: 0.112 +X-Spam-Level: +X-Spam-Status: No, score=0.112 tagged_above=-999 required=5 tests=[AWL=0.112] + autolearn=disabled +Received: from arlo.cworth.org ([127.0.0.1]) + by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id Cj5mR0bol3yv for ; + Fri, 25 Sep 2015 05:26:56 -0700 (PDT) +Received: from gitolite.debian.net (gitolite.debian.net [87.98.215.224]) + by arlo.cworth.org (Postfix) with ESMTPS id C7F446DE0B7C + for ; Fri, 25 Sep 2015 05:26:55 -0700 (PDT) +Received: from remotemail by gitolite.debian.net with local (Exim 4.80) + (envelope-from ) + id 1ZfS4Z-0004ur-HH; Fri, 25 Sep 2015 12:25:55 +0000 +Received: (nullmailer pid 19292 invoked by uid 1000); Fri, 25 Sep 2015 + 12:25:36 -0000 +From: David Bremner +To: Tomi Ollila , notmuch@notmuchmail.org +Subject: Re: [PATCH] test suite: don't consider skipped individual tests as + failing +In-Reply-To: +References: <1443093210-6511-1-git-send-email-david@tethera.net> + +User-Agent: Notmuch/0.20.2+73~gd432116 (http://notmuchmail.org) Emacs/24.5.1 + (x86_64-pc-linux-gnu) +Date: Fri, 25 Sep 2015 09:25:36 -0300 +Message-ID: <87twqi1y9r.fsf@zancas.localnet> +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.18 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Fri, 25 Sep 2015 12:26:57 -0000 + +Tomi Ollila writes: + +> +> Looks OK, but I think there should be (some good) comment here informing +> any potential viewer that we're not checking $skipped... +> + +I put some vaguely threatening comment in test/README, and a brief +comment in the file. I've merged the commit, but feel free to send +suggestions / patches for further doc changes. I more or less made up a +hypothetical future policy on the spot... + +d -- 2.26.2