From daba05c749d96fd834fe87ae58d18ea1f7aa0c1b Mon Sep 17 00:00:00 2001 From: Jani Nikula Date: Wed, 9 Oct 2013 21:25:39 +0300 Subject: [PATCH] Re: [PATCH 08/11] search: Add stable queries to thread search results --- 07/1d932879872a6b97e5047b98caa0c367af2bf7 | 95 +++++++++++++++++++++++ 1 file changed, 95 insertions(+) create mode 100644 07/1d932879872a6b97e5047b98caa0c367af2bf7 diff --git a/07/1d932879872a6b97e5047b98caa0c367af2bf7 b/07/1d932879872a6b97e5047b98caa0c367af2bf7 new file mode 100644 index 000000000..5e9eb7fca --- /dev/null +++ b/07/1d932879872a6b97e5047b98caa0c367af2bf7 @@ -0,0 +1,95 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 71C72431FAF + for ; Wed, 9 Oct 2013 11:25:50 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id tn6ZifxivhIS for ; + Wed, 9 Oct 2013 11:25:43 -0700 (PDT) +Received: from mail-ea0-f171.google.com (mail-ea0-f171.google.com + [209.85.215.171]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id B6D65431FAE + for ; Wed, 9 Oct 2013 11:25:42 -0700 (PDT) +Received: by mail-ea0-f171.google.com with SMTP id n15so609148ead.2 + for ; Wed, 09 Oct 2013 11:25:41 -0700 (PDT) +X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; + d=1e100.net; s=20130820; + h=x-gm-message-state:from:to:cc:subject:in-reply-to:references + :user-agent:date:message-id:mime-version:content-type; + bh=b09i//JDzWOD3kFoHLCAdHflnaXHqgr1W+ZprFPGD6w=; + b=Qh2PsupbIAbZXx0ycMXX/Cw2p9c+37AoMtkLIlxI5e7aKruP4tOYhVp+Q3aT3vyeOD + d+86l74LIPgPAdGEId2mWqAksjTeFydoPxczkpFS2h2DnVjQLc0tqrOXcxQfcNnWXWv7 + tTwA2NDqddEqc5nhs+eHroNrf27yGK8zj7dd9R/Kb52Q4+xKuoRblBFX/LRv5cLnD9R2 + vQY1INq8hjsHj0I3zo+Pkb+cpsFRxUGXFvyTXV+tDmTPWZIQ73dDRl2cgYchB2vJrKKd + d9X12hTlxI1Fy8ahSLP0qna91XQalk+mfwKK+DdjZiLCdb6pbEq8eqUyNUHRNTum0cI8 + zZfQ== +X-Gm-Message-State: + ALoCoQlhcKb/W/p77YOmjwvvLGBi9AmQSjlOKs4Tp5YOO99Wt1zpbWF6ImJptIrmiXWCQ0bgSqBq +X-Received: by 10.14.122.132 with SMTP id t4mr13771958eeh.20.1381343140206; + Wed, 09 Oct 2013 11:25:40 -0700 (PDT) +Received: from localhost (dsl-hkibrasgw2-58c36f-91.dhcp.inet.fi. + [88.195.111.91]) + by mx.google.com with ESMTPSA id m54sm91689038eex.2.1969.12.31.16.00.00 + (version=TLSv1.2 cipher=RC4-SHA bits=128/128); + Wed, 09 Oct 2013 11:25:38 -0700 (PDT) +From: Jani Nikula +To: Austin Clements +Subject: Re: [PATCH 08/11] search: Add stable queries to thread search results +In-Reply-To: <20131009143658.GQ21611@mit.edu> +References: <1381185201-25197-1-git-send-email-amdragon@mit.edu> + <1381185201-25197-9-git-send-email-amdragon@mit.edu> + <87fvsaao2q.fsf@nikula.org> <20131009143658.GQ21611@mit.edu> +User-Agent: Notmuch/0.16+88~g563143a (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-pc-linux-gnu) +Date: Wed, 09 Oct 2013 21:25:39 +0300 +Message-ID: <87a9iil2sc.fsf@nikula.org> +MIME-Version: 1.0 +Content-Type: text/plain +Cc: notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Wed, 09 Oct 2013 18:25:50 -0000 + +On Wed, 09 Oct 2013, Austin Clements wrote: +> Quoth Jani Nikula on Oct 09 at 9:41 am: +>> Also one talloc less. Which brings me to the main worry: +>> performance. What's the impact? +> +> Seems to be about 1%-3% for CLI search (tested on the medium corpus). +> It's hard to measure what the effect on Emacs search is, though I +> would expect it to be similarly negligible. + +I can live with that. :) + +> Some work I did several attempts at this ago suggests that this slows +> down tagging (though I doubt it would be noticeable for single +> threads), but I also found that switching to docid-based queries +> significantly sped things up: +> id:CAH-f9WsPj=1Eu=g3sOePJgCTBFs6HrLdLq18xMEnJ8aZ00yCEg@mail.gmail.com +> Actually, docid queries probably make tagging faster than it is *now*, +> but I didn't measure that when I did the experiments. + +Looks like there's a few hurdles in adding that concept +nicely. Something for the future. + +BR, +Jani. -- 2.26.2