From da6e95af47a674dd16afdf2de1ace36d6b4a86c8 Mon Sep 17 00:00:00 2001 From: David Bremner Date: Sun, 22 Nov 2015 07:50:06 +2000 Subject: [PATCH] Re: [PATCH] emacs: hello: fix accidental modification of widget-keymap --- e0/365fd3233623c1225df3fd60cf4c9f78370b1a | 68 +++++++++++++++++++++++ 1 file changed, 68 insertions(+) create mode 100644 e0/365fd3233623c1225df3fd60cf4c9f78370b1a diff --git a/e0/365fd3233623c1225df3fd60cf4c9f78370b1a b/e0/365fd3233623c1225df3fd60cf4c9f78370b1a new file mode 100644 index 000000000..18871161c --- /dev/null +++ b/e0/365fd3233623c1225df3fd60cf4c9f78370b1a @@ -0,0 +1,68 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by arlo.cworth.org (Postfix) with ESMTP id 72DE56DE1320 + for ; Sat, 21 Nov 2015 03:51:56 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at cworth.org +X-Spam-Flag: NO +X-Spam-Score: 0.092 +X-Spam-Level: +X-Spam-Status: No, score=0.092 tagged_above=-999 required=5 tests=[AWL=0.092] + autolearn=disabled +Received: from arlo.cworth.org ([127.0.0.1]) + by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id HVJ7Isjmt-qj for ; + Sat, 21 Nov 2015 03:51:54 -0800 (PST) +Received: from gitolite.debian.net (gitolite.debian.net [87.98.215.224]) + by arlo.cworth.org (Postfix) with ESMTPS id 4B72F6DE0A87 + for ; Sat, 21 Nov 2015 03:51:53 -0800 (PST) +Received: from remotemail by gitolite.debian.net with local (Exim 4.80) + (envelope-from ) + id 1a06gT-0003dK-FQ; Sat, 21 Nov 2015 11:50:25 +0000 +Received: (nullmailer pid 13560 invoked by uid 1000); Sat, 21 Nov 2015 + 11:50:06 -0000 +From: David Bremner +To: Mark Walters , notmuch@notmuchmail.org +Subject: Re: [PATCH] emacs: hello: fix accidental modification of + widget-keymap +In-Reply-To: <1447326139-13620-1-git-send-email-markwalters1009@gmail.com> +References: <1447326139-13620-1-git-send-email-markwalters1009@gmail.com> +User-Agent: Notmuch/0.21+7~g55fb7da (http://notmuchmail.org) Emacs/24.5.1 + (x86_64-pc-linux-gnu) +Date: Sat, 21 Nov 2015 07:50:06 -0400 +Message-ID: <87610v607l.fsf@zancas.localnet> +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.20 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sat, 21 Nov 2015 11:51:56 -0000 + +Mark Walters writes: + +> In emacs24 we use make-composed-keymap. It seems that if only a single +> map is specified then emacs just resuses it rather than creating a +> copy of it. Thus use make-sparse-keymap to force a copy. +> --- +> +> pseudomyne and the diredful author thamer found that we modify +> widget-keymap in notmuch. We clearly don't want to, and I think we +> tried not to, but emacs was being clever and reused the old keymap +> rather than creating a new one. + +I have tested this patch against the latest diredful.el and it seems to +be OK. Barring protests I'll apply it against release, and start to +build 0.21.1 ; not sure if we have any other suitable bug fixes to +include. + +d -- 2.26.2