From da0733207a4f33ac25fb9364f12fba663b134555 Mon Sep 17 00:00:00 2001 From: David Bremner Date: Tue, 24 Nov 2015 08:55:38 +2000 Subject: [PATCH] Re: [PATCH 1/4] emacs: notmuch-show-view-raw-message clears buffer, makes it read-only --- 1b/461f27d76b1f9912c63012e2278bfe7944b5a5 | 67 +++++++++++++++++++++++ 1 file changed, 67 insertions(+) create mode 100644 1b/461f27d76b1f9912c63012e2278bfe7944b5a5 diff --git a/1b/461f27d76b1f9912c63012e2278bfe7944b5a5 b/1b/461f27d76b1f9912c63012e2278bfe7944b5a5 new file mode 100644 index 000000000..5f0873883 --- /dev/null +++ b/1b/461f27d76b1f9912c63012e2278bfe7944b5a5 @@ -0,0 +1,67 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by arlo.cworth.org (Postfix) with ESMTP id F3CF86DE13DB + for ; Mon, 23 Nov 2015 04:55:41 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at cworth.org +X-Spam-Flag: NO +X-Spam-Score: -0.306 +X-Spam-Level: +X-Spam-Status: No, score=-0.306 tagged_above=-999 required=5 tests=[AWL=0.245, + RP_MATCHES_RCVD=-0.55, SPF_PASS=-0.001] autolearn=disabled +Received: from arlo.cworth.org ([127.0.0.1]) + by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id BF-y4teXqHdL for ; + Mon, 23 Nov 2015 04:55:40 -0800 (PST) +Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197]) + by arlo.cworth.org (Postfix) with ESMTPS id 44B376DE13DA + for ; Mon, 23 Nov 2015 04:55:40 -0800 (PST) +Received: from remotemail by fethera.tethera.net with local (Exim 4.84) + (envelope-from ) + id 1a0qeh-0000Xr-2w; Mon, 23 Nov 2015 07:55:39 -0500 +Received: (nullmailer pid 8922 invoked by uid 1000); + Mon, 23 Nov 2015 12:55:38 -0000 +From: David Bremner +To: Tomi Ollila , notmuch@notmuchmail.org +Cc: tomi.ollila@iki.fi +Subject: Re: [PATCH 1/4] emacs: notmuch-show-view-raw-message clears buffer, + makes it read-only +In-Reply-To: <1441204482-26509-1-git-send-email-tomi.ollila@iki.fi> +References: <1441204482-26509-1-git-send-email-tomi.ollila@iki.fi> +User-Agent: Notmuch/0.21+7~g55fb7da (http://notmuchmail.org) Emacs/24.5.1 + (x86_64-pc-linux-gnu) +Date: Mon, 23 Nov 2015 08:55:38 -0400 +Message-ID: <87fuzw50z9.fsf@zancas.localnet> +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.20 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Mon, 23 Nov 2015 12:55:42 -0000 + +Tomi Ollila writes: + +> notmuch-show-view-raw-message() re-uses buffer created with same +> name (same Message-Id:) but it did not erase it before filling. +> If this ever happened, there were duplicated (potentially overlapping) +> content in the buffer. Now this is fixed. +> Apparently since emacs 24.5 the (view-buffer) makes the buffer read-only; +> so this problem would not have happened there, just that +> notmuch-show-view-raw-message() failed. This is fixed by setting +> inhibit-read-only t before erasing and filling the buffer. The emacs 24.5 +> feature having raw message buffer read-only is also now explicitly set to +> the buffer so the same experience is available with emaces < 24.5. + +Applied this one patch to master + +d -- 2.26.2