From d5199424c5625a816a2a3204708905e76bfb71aa Mon Sep 17 00:00:00 2001 From: Joey Hess Date: Fri, 18 Jun 2010 12:50:31 -0400 Subject: [PATCH] avoid shelling --- IkiWiki/Plugin/bzr.pm | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/IkiWiki/Plugin/bzr.pm b/IkiWiki/Plugin/bzr.pm index e7c1b8d8e..9bee0c4b2 100644 --- a/IkiWiki/Plugin/bzr.pm +++ b/IkiWiki/Plugin/bzr.pm @@ -287,9 +287,7 @@ sub rcs_diff ($) { } sub extract_timestamp (@) { - # XXX filename passes through the shell here, should try to avoid - # that just in case - open (my $out, "@_ |"); + open (my $out, "-|", @_); my @log = bzr_log($out); if (length @log < 1) { -- 2.26.2