From d3e7984684262378810c745a382dcf84ce8c403e Mon Sep 17 00:00:00 2001 From: Tomi Ollila Date: Mon, 14 Apr 2014 22:48:08 +0300 Subject: [PATCH] Re: [PATCH] emacs: remove auto-signing of replies to signed messages --- 8b/29b96ccc1a05fc373edbc9a97de8ef0e58e556 | 104 ++++++++++++++++++++++ 1 file changed, 104 insertions(+) create mode 100644 8b/29b96ccc1a05fc373edbc9a97de8ef0e58e556 diff --git a/8b/29b96ccc1a05fc373edbc9a97de8ef0e58e556 b/8b/29b96ccc1a05fc373edbc9a97de8ef0e58e556 new file mode 100644 index 000000000..336dfd71e --- /dev/null +++ b/8b/29b96ccc1a05fc373edbc9a97de8ef0e58e556 @@ -0,0 +1,104 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 6057A431FC3 + for ; Mon, 14 Apr 2014 12:48:24 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id nOBOTcvn-1Jm for ; + Mon, 14 Apr 2014 12:48:13 -0700 (PDT) +Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) + by olra.theworths.org (Postfix) with ESMTP id 5AC02431FC0 + for ; Mon, 14 Apr 2014 12:48:13 -0700 (PDT) +Received: from guru.guru-group.fi (localhost [IPv6:::1]) + by guru.guru-group.fi (Postfix) with ESMTP id 9F9EC10008F; + Mon, 14 Apr 2014 22:48:08 +0300 (EEST) +From: Tomi Ollila +To: Jameson Graef Rollins , + Notmuch Mail +Subject: Re: [PATCH] emacs: remove auto-signing of replies to signed messages +In-Reply-To: <1397504450-15498-1-git-send-email-jrollins@finestructure.net> +References: <87mwfnd9eh.fsf@tethera.net> + <1397504450-15498-1-git-send-email-jrollins@finestructure.net> +User-Agent: Notmuch/0.17+201~g56da2d6 (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-unknown-linux-gnu) +X-Face: HhBM'cA~ +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Mon, 14 Apr 2014 19:48:24 -0000 + +On Mon, Apr 14 2014, Jameson Graef Rollins wrote: + +> It was decided that auto-signing is potentially too troublesome for the +> apparently common case of users who enable crypto processing for the +> purpose of checking signature validity but who are not in a position to +> sign out-going messages. Users can still manually invoke signing as needed. +> +> Encrypting replies to encrypted messages is more of a security issue +> so we leave it in place. +> --- + +LGTM. Works for me. +1 + +Tomi + + +> emacs/notmuch-mua.el | 7 +++---- +> 1 file changed, 3 insertions(+), 4 deletions(-) +> +> diff --git a/emacs/notmuch-mua.el b/emacs/notmuch-mua.el +> index bf6253f..95e4a4d 100644 +> --- a/emacs/notmuch-mua.el +> +++ b/emacs/notmuch-mua.el +> @@ -116,10 +116,9 @@ list." +> notmuch-mua-hidden-headers)) +> +> (defun notmuch-mua-reply-crypto (parts) +> + "Add mml sign-encrypt flag if any part of original message is encrypted." +> (loop for part in parts +> - if (notmuch-match-content-type (plist-get part :content-type) "multipart/signed") +> - do (mml-secure-message-sign) +> - else if (notmuch-match-content-type (plist-get part :content-type) "multipart/encrypted") +> + if (notmuch-match-content-type (plist-get part :content-type) "multipart/encrypted") +> do (mml-secure-message-sign-encrypt) +> else if (notmuch-match-content-type (plist-get part :content-type) "multipart/*") +> do (notmuch-mua-reply-crypto (plist-get part :content)))) +> @@ -236,7 +235,7 @@ list." +> ;; Quote the original message according to the user's configured style. +> (message-cite-original))) +> +> - ;; Sign and/or encrypt replies to signed and/or encrypted messages. +> + ;; Crypto processing based crypto content of the original message +> (when process-crypto +> (notmuch-mua-reply-crypto (plist-get original :body)))) +> +> -- +> 1.9.1 +> +> _______________________________________________ +> notmuch mailing list +> notmuch@notmuchmail.org +> http://notmuchmail.org/mailman/listinfo/notmuch -- 2.26.2