From d1f6c27b8bfcd37913ba95d860167704106acc2d Mon Sep 17 00:00:00 2001 From: Jani Nikula Date: Tue, 5 Nov 2013 12:15:19 +0100 Subject: [PATCH] Re: [PATCH v2 07/11] lib: use the compaction backup path provided by the caller --- d1/a86886e16890c8604eb76af655fa149092ad33 | 85 +++++++++++++++++++++++ 1 file changed, 85 insertions(+) create mode 100644 d1/a86886e16890c8604eb76af655fa149092ad33 diff --git a/d1/a86886e16890c8604eb76af655fa149092ad33 b/d1/a86886e16890c8604eb76af655fa149092ad33 new file mode 100644 index 000000000..e8fa24d21 --- /dev/null +++ b/d1/a86886e16890c8604eb76af655fa149092ad33 @@ -0,0 +1,85 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 1E607429E4F + for ; Tue, 5 Nov 2013 05:01:50 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id eZVMEhBklc5G for ; + Tue, 5 Nov 2013 05:01:42 -0800 (PST) +Received: from mail-wg0-f42.google.com (mail-wg0-f42.google.com + [74.125.82.42]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client + certificate requested) by olra.theworths.org (Postfix) with ESMTPS id + 60656429E45 for ; Tue, 5 Nov 2013 05:01:42 -0800 + (PST) +Received: by mail-wg0-f42.google.com with SMTP id n12so2973811wgh.5 + for ; Tue, 05 Nov 2013 05:01:40 -0800 (PST) +X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; + d=1e100.net; s=20130820; + h=x-gm-message-state:from:to:cc:subject:in-reply-to:references + :user-agent:date:message-id:mime-version:content-type; + bh=c40WBy0qJUCJgWzCWwkl6XGaeJSO1htEbbAx0/qSLZw=; + b=Ov8VAoAkKhVzyDMb7kmjZIT677eqThpZ11Ms/LLn33dTln6K5gpiIzsLDc4F9pmHQ8 + Poc1CJDSWQrFQEH6tQboeFH1sdIoBXQNmujNBBIWF+ss/SyRyUeCO7/sbSCzXtESFx+w + xQ2GoYR2o4cvSWNaTiAXUzVzd6N7sQuC/5vLQD5EY0dzEnNoG7fEHZJKu2XE9q+Q8lrS + oTgRiWYotBzP9k5kk0L3Do7hiL3tX0XHPtQm+CXIk82gvzh0rFpIShHMD9rBltGzk9Qi + ZYdhwgZ0heaphcIWcHmCzIA2FiBXYdajbCyusgoi7e75iSBxjei4WlZWz+qH7rLI322E + W2uQ== +X-Gm-Message-State: + ALoCoQnkggH5Y/43K9In1Oh65fxIFlOHZwfl98kYlRlY1n/dHbqmr9DbDju3RwR9dgCj/GEM5gyV +X-Received: by 10.180.160.165 with SMTP id xl5mr15989336wib.48.1383650137413; + Tue, 05 Nov 2013 03:15:37 -0800 (PST) +Received: from localhost ([2001:4b98:dc0:43:216:3eff:fe1b:25f3]) + by mx.google.com with ESMTPSA id fu1sm13567130wib.8.2013.11.05.03.15.34 + for + (version=TLSv1.1 cipher=RC4-SHA bits=128/128); + Tue, 05 Nov 2013 03:15:36 -0800 (PST) +From: Jani Nikula +To: David Bremner , notmuch@notmuchmail.org +Subject: Re: [PATCH v2 07/11] lib: use the compaction backup path provided by + the caller +In-Reply-To: <87ob5zqft7.fsf@zancas.localnet> +References: + <6e8053834c8ab856c2ebab881069f18b2badcf71.1383481295.git.jani@nikula.org> + <87ob5zqft7.fsf@zancas.localnet> +User-Agent: Notmuch/0.16+115~gd647c65 (http://notmuchmail.org) Emacs/23.2.1 + (x86_64-pc-linux-gnu) +Date: Tue, 05 Nov 2013 12:15:19 +0100 +Message-ID: <87sivb9k1k.fsf@nikula.org> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Tue, 05 Nov 2013 13:01:50 -0000 + +On Tue, 05 Nov 2013, David Bremner wrote: +> Jani Nikula writes: +> +>> + backup_path = talloc_asprintf (config, "%s/xapian.old", path); +>> + if (! backup_path) +>> + return 1; +>> + +> +> Is it intentional that no message is printed here? A random glance at +> notmuch-search.c suggests we usually print a message on OOM in the CLI. + +Oversight. + +Jani. -- 2.26.2