From d16d193f0bc216c352526c91788aa798586e3d93 Mon Sep 17 00:00:00 2001 From: Jani Nikula Date: Sun, 30 Aug 2015 10:33:04 +0300 Subject: [PATCH] Re: [RFC PATCH 3/5] cli: add support for not deduplicating notmuch address results --- cc/fb2c7e09fb0a6639e076199061557b04116f18 | 93 +++++++++++++++++++++++ 1 file changed, 93 insertions(+) create mode 100644 cc/fb2c7e09fb0a6639e076199061557b04116f18 diff --git a/cc/fb2c7e09fb0a6639e076199061557b04116f18 b/cc/fb2c7e09fb0a6639e076199061557b04116f18 new file mode 100644 index 000000000..991aa6e78 --- /dev/null +++ b/cc/fb2c7e09fb0a6639e076199061557b04116f18 @@ -0,0 +1,93 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by arlo.cworth.org (Postfix) with ESMTP id 9F8F96DE00CB + for ; Sun, 30 Aug 2015 00:33:10 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at cworth.org +X-Spam-Flag: NO +X-Spam-Score: -0.035 +X-Spam-Level: +X-Spam-Status: No, score=-0.035 tagged_above=-999 required=5 + tests=[AWL=-0.059, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01, + RCVD_IN_MSPIKE_WL=-0.01, URIBL_SBL=0.644, URIBL_SBL_A=0.1] + autolearn=disabled +Received: from arlo.cworth.org ([127.0.0.1]) + by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id 37le4-320Mhi for ; + Sun, 30 Aug 2015 00:33:08 -0700 (PDT) +Received: from mail-wi0-f171.google.com (mail-wi0-f171.google.com + [209.85.212.171]) + by arlo.cworth.org (Postfix) with ESMTPS id 6736A6DE005F + for ; Sun, 30 Aug 2015 00:33:08 -0700 (PDT) +Received: by wizs10 with SMTP id s10so2443539wiz.1 + for ; Sun, 30 Aug 2015 00:33:06 -0700 (PDT) +X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; + d=1e100.net; s=20130820; + h=x-gm-message-state:from:to:subject:in-reply-to:references + :user-agent:date:message-id:mime-version:content-type; + bh=tMyqtdCrrFb2wQI/8fZ297PQxDca9Fl49vkXhhIQwf4=; + b=IBOL25QnvN9iei+jChGFVdVOrUSYyF7y6jh4pGTTOl0d/3/LTzHU5a3brY7ILL5xS/ + /m93obcsvzL6k46X+uTqMTAMTrNZUAMniGyPUN/59uIGpkht8NXqymrlsUr7OHnDe3CW + HB2rU57xNxcptGyf5yce/etPU+4BevjkNZ//bbHaaz0u1Z00C+AahTdJZk3D0WYnJPGT + sLN0VfhhXRPpvPGonBoVA5/dAovNaXXic7paHL7hCbGjRO0CsWeuUxJ45tyh19Z+CNH6 + q0bfDWzGwkN6MXgkEhf1KYDMJtmHptsEYLHnTsrGaRDqc0qxoVgXRjhZ4qudS5cmHEgs + Ha7g== +X-Gm-Message-State: + ALoCoQkFmyG8VD4DoBP2GZxdaDa8FancyR7vXgLUZhY5KwNPv/bKXbNwh/hoaiZYai48KjlGV0uV +X-Received: by 10.194.122.200 with SMTP id lu8mr19114548wjb.83.1440919985829; + Sun, 30 Aug 2015 00:33:05 -0700 (PDT) +Received: from localhost (mobile-access-bcee4f-131.dhcp.inet.fi. + [188.238.79.131]) + by smtp.gmail.com with ESMTPSA id j2sm16173181wjq.5.2015.08.30.00.33.04 + (version=TLSv1/SSLv3 cipher=OTHER); + Sun, 30 Aug 2015 00:33:05 -0700 (PDT) +From: Jani Nikula +To: David Bremner , notmuch@notmuchmail.org +Subject: Re: [RFC PATCH 3/5] cli: add support for not deduplicating notmuch + address results +In-Reply-To: <87d1y5tvg5.fsf@maritornes.cs.unb.ca> +References: + <5badd1d1d46690987558dd2283efdc69be4c8c99.1440859765.git.jani@nikula.org> + <87d1y5tvg5.fsf@maritornes.cs.unb.ca> +User-Agent: Notmuch/0.20.2+66~gb33abd9 (http://notmuchmail.org) Emacs/24.4.1 + (x86_64-pc-linux-gnu) +Date: Sun, 30 Aug 2015 10:33:04 +0300 +Message-ID: <87k2sd1b9r.fsf@nikula.org> +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.18 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sun, 30 Aug 2015 07:33:10 -0000 + +On Sun, 30 Aug 2015, David Bremner wrote: +> Jani Nikula writes: +> +> +>> + { NOTMUCH_OPT_KEYWORD, &ctx->dupe, "deduplicate", 'x', +> +> probably you want 'D' or 'd' here. Not that it makes a practical +> difference at this point. +> +>> + (notmuch_keyword_t []){ { "yes", -1 }, +> +> I'm not very enthusiastic about reusing ctx->dupe for this. +> In particular the use of -1 for yes is off-putting +> It seems better to allocate another word of memory and use an +> enum, as elsewhere. + +Agreed on both. + +BR, +Jani. + -- 2.26.2