From d044c72c3aa2b98e3e87b778eb2589d03cef820e Mon Sep 17 00:00:00 2001 From: Jani Nikula Date: Sun, 12 May 2013 23:02:26 +0300 Subject: [PATCH] Re: Solaris support - missing or incompatible functions --- 10/4609bb5c956459e1b6a77673eb74c11970d536 | 86 +++++++++++++++++++++++ 1 file changed, 86 insertions(+) create mode 100644 10/4609bb5c956459e1b6a77673eb74c11970d536 diff --git a/10/4609bb5c956459e1b6a77673eb74c11970d536 b/10/4609bb5c956459e1b6a77673eb74c11970d536 new file mode 100644 index 000000000..06cfd8f14 --- /dev/null +++ b/10/4609bb5c956459e1b6a77673eb74c11970d536 @@ -0,0 +1,86 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id E7378431FAE + for ; Sun, 12 May 2013 13:02:42 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id 8by+0qBH1o4Q for ; + Sun, 12 May 2013 13:02:38 -0700 (PDT) +Received: from mail-lb0-f178.google.com (mail-lb0-f178.google.com + [209.85.217.178]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 46DB2431FB6 + for ; Sun, 12 May 2013 13:02:38 -0700 (PDT) +Received: by mail-lb0-f178.google.com with SMTP id p10so2038874lbv.37 + for ; Sun, 12 May 2013 13:02:35 -0700 (PDT) +X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; + d=google.com; s=20120113; + h=x-received:from:to:subject:in-reply-to:references:user-agent:date + :message-id:mime-version:content-type:x-gm-message-state; + bh=nR4LT5nX80zUoG/rDMzTdkzmJTTKQ2vtXlbv8DNEIJE=; + b=G0rd+PrmNvmnZh60x4xWwJmV0sOm40ZYVpDSHVPPCGWZTlFLp1LCAkTUhzdeaBRYB1 + CfpUEdSh1Mbjb6w0dLwlk9MZ9T3vCjb3RYIdJt+QiHJH9MV1RDGW2/11kU1vRro4b8Aw + 513cyBf5cBBHVe8rEPOfFk429ZhkLIoLA6oO6ZOtl9D/YckimQZYqNiQ6HEFjT5l9XMf + JV0Hd9VoutETRTi+MxGKiIoQj1Zgphn6nTKLTBNSFUrmvWtP+b1qjMkyCI4E65sRvhEo + +gGc2eqEXbSzL7qOS7wZvYj1IK51aSDGP4/9sb5ROwcK4gHvQ0DqXJLHcTbxm5vWe+Hb + qCiQ== +X-Received: by 10.112.133.200 with SMTP id pe8mr11467126lbb.50.1368388955341; + Sun, 12 May 2013 13:02:35 -0700 (PDT) +Received: from localhost (dsl-hkibrasgw2-58c376-211.dhcp.inet.fi. + [88.195.118.211]) + by mx.google.com with ESMTPSA id h2sm4539302lah.4.2013.05.12.13.02.33 + for + (version=TLSv1.2 cipher=RC4-SHA bits=128/128); + Sun, 12 May 2013 13:02:34 -0700 (PDT) +From: Jani Nikula +To: Vladimir.Marek@oracle.com, notmuch@notmuchmail.org +Subject: Re: Solaris support - missing or incompatible functions +In-Reply-To: <1367853362-11846-1-git-send-email-Vladimir.Marek@oracle.com> +References: <1367853362-11846-1-git-send-email-Vladimir.Marek@oracle.com> +User-Agent: Notmuch/0.15.2+87~gc69f540 (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-pc-linux-gnu) +Date: Sun, 12 May 2013 23:02:26 +0300 +Message-ID: <87ehdc9dbh.fsf@nikula.org> +MIME-Version: 1.0 +Content-Type: text/plain +X-Gm-Message-State: + ALoCoQmPRq6yNJekrCTmxoWCuxodehw/MySMgjqTSS0gh57u/D0bxZ7Rm1oZchx0o0n2oC0nQdkk +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sun, 12 May 2013 20:02:43 -0000 + +On Mon, 06 May 2013, Vladimir.Marek@oracle.com wrote: +> I can't run the notmuch 'make test' on Solaris (too old bash) and on linux the +> results are +> +> 421/525 tests passed. +> 25 tests failed. +> 79 tests skipped. +> +> but they are the same without my changes too ... + +The series LGTM, except I didn't pay much attention to the timegm() +implementation. I hope the time parsing tests pass though. If they do, +and you think the implementation is good enough, then who am I to +argue. ;) + +BR, +Jani. -- 2.26.2