From cfec01b51e9d67e6dfcab579acff4e663a3733a0 Mon Sep 17 00:00:00 2001 From: David Bremner Date: Tue, 23 Jun 2015 22:31:38 +0200 Subject: [PATCH] Re: [PATCH] emacs: tree: mark read change --- d4/64a5210e5e9315da09869b8bf41009d991ba57 | 73 +++++++++++++++++++++++ 1 file changed, 73 insertions(+) create mode 100644 d4/64a5210e5e9315da09869b8bf41009d991ba57 diff --git a/d4/64a5210e5e9315da09869b8bf41009d991ba57 b/d4/64a5210e5e9315da09869b8bf41009d991ba57 new file mode 100644 index 000000000..4e9faeef4 --- /dev/null +++ b/d4/64a5210e5e9315da09869b8bf41009d991ba57 @@ -0,0 +1,73 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by arlo.cworth.org (Postfix) with ESMTP id 2F3B96DE0298 + for ; Tue, 23 Jun 2015 13:33:33 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at cworth.org +X-Spam-Flag: NO +X-Spam-Score: 0.18 +X-Spam-Level: +X-Spam-Status: No, score=0.18 tagged_above=-999 required=5 tests=[AWL=0.180] + autolearn=disabled +Received: from arlo.cworth.org ([127.0.0.1]) + by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id 7xngYn-58THb for ; + Tue, 23 Jun 2015 13:33:31 -0700 (PDT) +Received: from mx.xen14.node3324.gplhost.com (gitolite.debian.net + [87.98.215.224]) + by arlo.cworth.org (Postfix) with ESMTPS id C9EA06DE028A + for ; Tue, 23 Jun 2015 13:33:30 -0700 (PDT) +Received: from remotemail by mx.xen14.node3324.gplhost.com with local (Exim + 4.80) (envelope-from ) + id 1Z7UrN-0006FM-0J; Tue, 23 Jun 2015 20:31:57 +0000 +Received: (nullmailer pid 16804 invoked by uid 1000); Tue, 23 Jun 2015 + 20:31:38 -0000 +From: David Bremner +To: Mark Walters , notmuch@notmuchmail.org +Subject: Re: [PATCH] emacs: tree: mark read change +In-Reply-To: <1433843467-32398-1-git-send-email-markwalters1009@gmail.com> +References: <1433843467-32398-1-git-send-email-markwalters1009@gmail.com> +User-Agent: Notmuch/0.20.1+2~g5e37568 (http://notmuchmail.org) Emacs/24.4.1 + (x86_64-pc-linux-gnu) +Date: Tue, 23 Jun 2015 22:31:38 +0200 +Message-ID: <87si9iyxn9.fsf@maritornes.cs.unb.ca> +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.18 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Tue, 23 Jun 2015 20:33:33 -0000 + +Mark Walters writes: + +> The mark read code for tree mode did not get updated in the recent +> changes. This updates it to match. Since the user can customize the +> mark read logic we just call the show logic in the message pane. +> --- +> +> An alternative would be to mark any message explicitly viewed in +> tree-mode as read. That would be simpler but I think this is better as +> it deals with user customized mark read functions -- for example if +> the user has a customized function that only marks a message read if +> the whole message is viewed then this version will do the same in tree +> mode. + +At first I was leery of the chaining of hooks, but now that I +noticed/experienced the bug, it makes more sense to me. I'm considering +rolling a bug fix release with this (I imagine the bug is pretty +annoying for people using only notmuch-tree), so I'd like a bit more +feedback before merging it. + +d + + -- 2.26.2