From cfa0244b9ea84fe923d1e40614ccbad74198d4b2 Mon Sep 17 00:00:00 2001 From: Tomi Ollila Date: Sun, 2 Jun 2013 17:34:17 +0300 Subject: [PATCH] Re: [PATCH] contrib: pick: bugfix. use notmuch-show-only-matching-messages rather than prefix --- 1c/9b12487acfedcfc80f55317843e21ea4c16a7d | 90 +++++++++++++++++++++++ 1 file changed, 90 insertions(+) create mode 100644 1c/9b12487acfedcfc80f55317843e21ea4c16a7d diff --git a/1c/9b12487acfedcfc80f55317843e21ea4c16a7d b/1c/9b12487acfedcfc80f55317843e21ea4c16a7d new file mode 100644 index 000000000..5fb40dff5 --- /dev/null +++ b/1c/9b12487acfedcfc80f55317843e21ea4c16a7d @@ -0,0 +1,90 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id EC738429E55 + for ; Sun, 2 Jun 2013 07:34:23 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id N2zcNEJ+PPA0 for ; + Sun, 2 Jun 2013 07:34:18 -0700 (PDT) +Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) + by olra.theworths.org (Postfix) with ESMTP id 95C53429E4C + for ; Sun, 2 Jun 2013 07:34:18 -0700 (PDT) +Received: from guru.guru-group.fi (localhost [IPv6:::1]) + by guru.guru-group.fi (Postfix) with ESMTP id EF418100030; + Sun, 2 Jun 2013 17:34:17 +0300 (EEST) +From: Tomi Ollila +To: Mark Walters , notmuch@notmuchmail.org +Subject: Re: [PATCH] contrib: pick: bugfix. use + notmuch-show-only-matching-messages rather than prefix +In-Reply-To: <1370123491-13902-1-git-send-email-markwalters1009@gmail.com> +References: <1370123491-13902-1-git-send-email-markwalters1009@gmail.com> +User-Agent: Notmuch/0.15.2+115~g12cf6af (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-unknown-linux-gnu) +X-Face: HhBM'cA~ +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sun, 02 Jun 2013 14:34:24 -0000 + +On Sun, Jun 02 2013, Mark Walters wrote: + +> Previously pick set a prefix argument prior to calling show in the +> message pane to tell show to only show matching messages. This sets +> notmuch-show-only-matching-messages instead which is much cleaner and +> will work even if the user has configured show to default to showing +> only matching messages. +> --- + +LGTM. + +Tomi + + +> contrib/notmuch-pick/notmuch-pick.el | 4 ++-- +> 1 files changed, 2 insertions(+), 2 deletions(-) +> +> diff --git a/contrib/notmuch-pick/notmuch-pick.el b/contrib/notmuch-pick/notmuch-pick.el +> index 9079acf..2da43ea 100644 +> --- a/contrib/notmuch-pick/notmuch-pick.el +> +++ b/contrib/notmuch-pick/notmuch-pick.el +> @@ -376,8 +376,8 @@ Does NOT change the database." +> (split-window-vertically (/ (window-height) 4))) +> (with-selected-window notmuch-pick-message-window +> ;; Since we are only displaying one message do not indent. +> - (let ((notmuch-show-indent-messages-width 0)) +> - (setq current-prefix-arg '(4)) +> + (let ((notmuch-show-indent-messages-width 0) +> + (notmuch-show-only-matching-messages t)) +> (setq buffer (notmuch-show id nil nil nil)))) +> ;; We need the `let' as notmuch-pick-message-window is buffer local. +> (let ((window notmuch-pick-message-window)) +> -- +> 1.7.9.1 +> +> _______________________________________________ +> notmuch mailing list +> notmuch@notmuchmail.org +> http://notmuchmail.org/mailman/listinfo/notmuch -- 2.26.2