From ce2c6ce061560dd93758611f15cc4bb1f01a7352 Mon Sep 17 00:00:00 2001 From: Tomi Ollila Date: Wed, 5 Feb 2014 17:00:45 +0200 Subject: [PATCH] Re: [PATCH 00/17] nmbug-status: Python-3-compabitility and general refactoring --- 17/1c40b0a73896aa18cbfa01276c8945c998c56e | 111 ++++++++++++++++++++++ 1 file changed, 111 insertions(+) create mode 100644 17/1c40b0a73896aa18cbfa01276c8945c998c56e diff --git a/17/1c40b0a73896aa18cbfa01276c8945c998c56e b/17/1c40b0a73896aa18cbfa01276c8945c998c56e new file mode 100644 index 000000000..03636d9dc --- /dev/null +++ b/17/1c40b0a73896aa18cbfa01276c8945c998c56e @@ -0,0 +1,111 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 1B008431FBC + for ; Wed, 5 Feb 2014 07:00:59 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id WhTFB5yGozl6 for ; + Wed, 5 Feb 2014 07:00:51 -0800 (PST) +Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) + by olra.theworths.org (Postfix) with ESMTP id A2A2F431FAE + for ; Wed, 5 Feb 2014 07:00:51 -0800 (PST) +Received: from guru.guru-group.fi (localhost [IPv6:::1]) + by guru.guru-group.fi (Postfix) with ESMTP id 9B119100033; + Wed, 5 Feb 2014 17:00:45 +0200 (EET) +From: Tomi Ollila +To: "W. Trevor King" +Subject: Re: [PATCH 00/17] nmbug-status: Python-3-compabitility and general + refactoring +In-Reply-To: +References: + + <20140204005331.GQ14197@odin.tremily.us> + + <20140204161142.GS14197@odin.tremily.us> + + <20140204191453.GV14197@odin.tremily.us> + +User-Agent: Notmuch/0.17+55~g4397960 (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-unknown-linux-gnu) +X-Face: HhBM'cA~ +MIME-Version: 1.0 +Content-Type: text/plain +Cc: notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Wed, 05 Feb 2014 15:00:59 -0000 + +On Tue, Feb 04 2014, Tomi Ollila wrote: + +> On Tue, Feb 04 2014, "W. Trevor King" wrote: +> +> +> $ PYTHONPATH=$PWD/bindings/python/ ./devel/nmbug/nmbug-status +> ... +> Traceback (most recent call last): +> File "devel/nmbug/nmbug-status", line 318, in +> page.write(database=db, views=config['views']) +> File "devel/nmbug/nmbug-status", line 94, in write +> self._write_view(database=database, view=view, stream=stream) +> File "devel/nmbug/nmbug-status", line 113, in _write_view +> self._write_threads(threads=threads, stream=stream) +> File "devel/nmbug/nmbug-status", line 215, in _write_threads +> ).format(**message_display_data)) +> File "/usr/lib64/python2.6/codecs.py", line 351, in write +> data, consumed = self.encode(object, self.errors) +> UnicodeEncodeError: 'ascii' codec can't encode character u'\u017b' in +> position 176: ordinal not in range(128) +> +> +> I'll dig deeper tomorrow. + +PEBKAC. I (actually) used wrapper to run nmbug-status -- to run right +notmuch binary. While it mostly sets environment to be right it internally +uses LC_ALL=C for consistency -- and the wrapper forgot to restore +LC_ALL before running nmbug-status. + +(that also confirms that the suggestion you made I used cron was somewhat +accurate ;) + +After I fixed the wrapper the program works fine on python 2.6.6. + +I have some comments on the new look -- which is pretty nice btw. + +now every other thread is background-colored (girly) pink (fef?) +and every other light blue (eff). for me the light blue is not +visible (there are no body background color set?) + +... hmm, i added 'body { background-color: #FFF; }' to the page and +still light blue is not visible on my screen (checked w/ #f0f that +the above line actually has some effect)... #DFF for the light-blue +works better for me. + +I think rounded corners are nice but IMHO the round radius is too big +-- using 0.5mm for the radius would IMHO be better. + +> +> Tomi + +Tomi -- 2.26.2