From c82fa8acb101d688c38efbc7ac06d5fe71609919 Mon Sep 17 00:00:00 2001 From: David Bremner Date: Sun, 28 Feb 2016 11:55:15 +2000 Subject: [PATCH] Re: [PATCH v3 11/16] add --try-decrypt to notmuch insert --- f4/47a10251a53fc2cba4fce16d762f69b1ca35c0 | 67 +++++++++++++++++++++++ 1 file changed, 67 insertions(+) create mode 100644 f4/47a10251a53fc2cba4fce16d762f69b1ca35c0 diff --git a/f4/47a10251a53fc2cba4fce16d762f69b1ca35c0 b/f4/47a10251a53fc2cba4fce16d762f69b1ca35c0 new file mode 100644 index 000000000..8834ad1a3 --- /dev/null +++ b/f4/47a10251a53fc2cba4fce16d762f69b1ca35c0 @@ -0,0 +1,67 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by arlo.cworth.org (Postfix) with ESMTP id 30A666DE13D2 + for ; Sat, 27 Feb 2016 07:55:21 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at cworth.org +X-Spam-Flag: NO +X-Spam-Score: -0.035 +X-Spam-Level: +X-Spam-Status: No, score=-0.035 tagged_above=-999 required=5 + tests=[AWL=-0.024, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] + autolearn=disabled +Received: from arlo.cworth.org ([127.0.0.1]) + by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id JLmgaIO0iiXK for ; + Sat, 27 Feb 2016 07:55:19 -0800 (PST) +Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197]) + by arlo.cworth.org (Postfix) with ESMTPS id 8682D6DE0FFA + for ; Sat, 27 Feb 2016 07:55:19 -0800 (PST) +Received: from remotemail by fethera.tethera.net with local (Exim 4.84) + (envelope-from ) + id 1aZhDq-0000HH-0Q; Sat, 27 Feb 2016 10:55:58 -0500 +Received: (nullmailer pid 26789 invoked by uid 1000); + Sat, 27 Feb 2016 15:55:15 -0000 +From: David Bremner +To: Daniel Kahn Gillmor , + Notmuch Mail +Subject: Re: [PATCH v3 11/16] add --try-decrypt to notmuch insert +In-Reply-To: <1454272801-23623-12-git-send-email-dkg@fifthhorseman.net> +References: <1454272801-23623-1-git-send-email-dkg@fifthhorseman.net> + <1454272801-23623-12-git-send-email-dkg@fifthhorseman.net> +User-Agent: Notmuch/0.21+26~g9404723 (http://notmuchmail.org) Emacs/24.5.1 + (x86_64-pc-linux-gnu) +Date: Sat, 27 Feb 2016 11:55:15 -0400 +Message-ID: <87vb5a407w.fsf@zancas.localnet> +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.20 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sat, 27 Feb 2016 15:55:21 -0000 + +Daniel Kahn Gillmor writes: +> + if (try_decrypt) { +> + const char* gpg_path = notmuch_config_get_crypto_gpg_path (config); +> + status = notmuch_indexopts_set_gpg_path (indexopts, gpg_path); +> + if (status) +> + fprintf (stderr, "Warning: failed to set database gpg_path to '%s' (%s)\n", +> + gpg_path ? gpg_path : "(NULL)", +> + notmuch_status_to_string (status)); +> + } + +Should this really be non-fatal event? I agree that the indexing can +carry on, but are there reasons for this to fail that don't indicate +something has gone really wrong? + +d -- 2.26.2