From c7a113aa479e9f99bab2c0419db12bb3fd76d6de Mon Sep 17 00:00:00 2001 From: David Bremner Date: Wed, 14 Sep 2011 08:39:22 +2100 Subject: [PATCH] Re: [PATCH] test: reset test_subtest_known_broken_ after each success/failure. --- 29/4d5ef8b9dde5f0f4eaa3ccf0147a4835113734 | 70 +++++++++++++++++++++++ 1 file changed, 70 insertions(+) create mode 100644 29/4d5ef8b9dde5f0f4eaa3ccf0147a4835113734 diff --git a/29/4d5ef8b9dde5f0f4eaa3ccf0147a4835113734 b/29/4d5ef8b9dde5f0f4eaa3ccf0147a4835113734 new file mode 100644 index 000000000..5ff47a1bf --- /dev/null +++ b/29/4d5ef8b9dde5f0f4eaa3ccf0147a4835113734 @@ -0,0 +1,70 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 8B700429E25 + for ; Tue, 13 Sep 2011 04:39:29 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -2.3 +X-Spam-Level: +X-Spam-Status: No, score=-2.3 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id TCkh8tVdsdu0 for ; + Tue, 13 Sep 2011 04:39:28 -0700 (PDT) +Received: from tempo.its.unb.ca (tempo.its.unb.ca [131.202.1.21]) + (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id C2410431FB6 + for ; Tue, 13 Sep 2011 04:39:28 -0700 (PDT) +Received: from zancas.localnet + (fctnnbsc36w-156034073093.pppoe-dynamic.High-Speed.nb.bellaliant.net + [156.34.73.93]) (authenticated bits=0) + by tempo.its.unb.ca (8.13.8/8.13.8) with ESMTP id p8DBdNDI024917 + (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NO); + Tue, 13 Sep 2011 08:39:23 -0300 +Received: from bremner by zancas.localnet with local (Exim 4.76) + (envelope-from ) + id 1R3RKk-0007B3-N5; Tue, 13 Sep 2011 08:39:22 -0300 +From: David Bremner +To: Dmitry Kurochkin , notmuch@notmuchmail.org +Subject: Re: [PATCH] test: reset test_subtest_known_broken_ after each + success/failure. +In-Reply-To: <87vcswd9s7.fsf@gmail.com> +References: <87obyqvc4s.fsf@gmail.com> + <1315881714-23759-1-git-send-email-david@tethera.net> + <87vcswd9s7.fsf@gmail.com> +User-Agent: Notmuch/0.8 (http://notmuchmail.org) Emacs/23.3.1 + (x86_64-pc-linux-gnu) +Date: Tue, 13 Sep 2011 08:39:22 -0300 +Message-ID: <87bouowu1h.fsf@zancas.localnet> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Tue, 13 Sep 2011 11:39:29 -0000 + +On Tue, 13 Sep 2011 14:19:36 +0400, Dmitry Kurochkin wrote: +> > The assumption is that every test ends up calling either skipping, +> > calling test_ok_ or test_failure_ and and the latter in turn delegate +> > to the known_broken versions in the case where +> > test_subtest_known_broken_ is set. +> +> Looks good to me. +> +> Regards, +> Dmitry + +OK, pushed. -- 2.26.2