From c780d3712bc12fd71b5153ed36f47b2a38293766 Mon Sep 17 00:00:00 2001 From: David Bremner Date: Sat, 1 Aug 2015 22:47:08 +0200 Subject: [PATCH] Re: [PATCH] emacs: show: let the user override the mime-type of an attachment --- c6/6434e69b289c290f5b6e43858accffe40935ca | 69 +++++++++++++++++++++++ 1 file changed, 69 insertions(+) create mode 100644 c6/6434e69b289c290f5b6e43858accffe40935ca diff --git a/c6/6434e69b289c290f5b6e43858accffe40935ca b/c6/6434e69b289c290f5b6e43858accffe40935ca new file mode 100644 index 000000000..657f394ce --- /dev/null +++ b/c6/6434e69b289c290f5b6e43858accffe40935ca @@ -0,0 +1,69 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by arlo.cworth.org (Postfix) with ESMTP id 055FE6DE1585 + for ; Sat, 1 Aug 2015 13:48:54 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at cworth.org +X-Spam-Flag: NO +X-Spam-Score: 0.147 +X-Spam-Level: +X-Spam-Status: No, score=0.147 tagged_above=-999 required=5 tests=[AWL=0.147] + autolearn=disabled +Received: from arlo.cworth.org ([127.0.0.1]) + by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id SR5qXoKWle5m for ; + Sat, 1 Aug 2015 13:48:51 -0700 (PDT) +Received: from gitolite.debian.net (gitolite.debian.net [87.98.215.224]) + by arlo.cworth.org (Postfix) with ESMTPS id CF4256DE1533 + for ; Sat, 1 Aug 2015 13:48:50 -0700 (PDT) +Received: from remotemail by gitolite.debian.net with local (Exim 4.80) + (envelope-from ) + id 1ZLdgg-0006oJ-JR; Sat, 01 Aug 2015 20:47:22 +0000 +Received: (nullmailer pid 30970 invoked by uid 1000); Sat, 01 Aug 2015 + 20:47:08 -0000 +From: David Bremner +To: Mark Walters , notmuch@notmuchmail.org +Subject: Re: [PATCH] emacs: show: let the user override the mime-type of an + attachment +In-Reply-To: <1435702585-27363-1-git-send-email-markwalters1009@gmail.com> +References: <1435702585-27363-1-git-send-email-markwalters1009@gmail.com> +User-Agent: Notmuch/0.20.2 (http://notmuchmail.org) Emacs/24.5.1 + (x86_64-pc-linux-gnu) +Date: Sat, 01 Aug 2015 22:47:08 +0200 +Message-ID: <87mvyaenxv.fsf@maritornes.cs.unb.ca> +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.18 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sat, 01 Aug 2015 20:48:54 -0000 + +Mark Walters writes: + +> +(defun notmuch-show-internal-mm-display-part (handle) + +It's very much a quibble, but I don't understand the naming scheme +here. Is internal meant to denote an privateish function? If so the +convention of using -- (notmuch-show--mm-display-part, I guess) seems +more common in the code base. Or does internal/external refer to viewers +here? + +Otherwise, it looks good. The only thing that I really missed was +completion on mime types. But that makes sense as a seperate patch, even +if it is easy, and I have no idea how easy it is. + +d + + + + -- 2.26.2