From c6bc13953dcb1a4ce968a2b0316edac9427df930 Mon Sep 17 00:00:00 2001 From: Daniel Kahn Gillmor Date: Sun, 10 Apr 2016 14:55:29 +2000 Subject: [PATCH] Re: [PATCH v4 7/7] complete ghost-on-removal-when-shared-thread-exists --- 46/fa7b0c7c320a184708c0056bd6cfa02053a1e0 | 86 +++++++++++++++++++++++ 1 file changed, 86 insertions(+) create mode 100644 46/fa7b0c7c320a184708c0056bd6cfa02053a1e0 diff --git a/46/fa7b0c7c320a184708c0056bd6cfa02053a1e0 b/46/fa7b0c7c320a184708c0056bd6cfa02053a1e0 new file mode 100644 index 000000000..52b8d5b98 --- /dev/null +++ b/46/fa7b0c7c320a184708c0056bd6cfa02053a1e0 @@ -0,0 +1,86 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by arlo.cworth.org (Postfix) with ESMTP id 994386DE02BF + for ; Sat, 9 Apr 2016 11:55:50 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at cworth.org +X-Spam-Flag: NO +X-Spam-Score: -0.026 +X-Spam-Level: +X-Spam-Status: No, score=-0.026 tagged_above=-999 required=5 + tests=[AWL=-0.026] autolearn=disabled +Received: from arlo.cworth.org ([127.0.0.1]) + by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id O8AxVU4TBj_P for ; + Sat, 9 Apr 2016 11:55:42 -0700 (PDT) +Received: from che.mayfirst.org (che.mayfirst.org [209.234.253.108]) + by arlo.cworth.org (Postfix) with ESMTP id A970D6DE00BD + for ; Sat, 9 Apr 2016 11:55:42 -0700 (PDT) +Received: from fifthhorseman.net (ool-6c3a0662.static.optonline.net + [108.58.6.98]) + by che.mayfirst.org (Postfix) with ESMTPSA id 08FD0FDB7; + Sat, 9 Apr 2016 14:55:29 -0400 (EDT) +Received: by fifthhorseman.net (Postfix, from userid 1000) + id 305781FD92; Sat, 9 Apr 2016 14:55:29 -0400 (EDT) +From: Daniel Kahn Gillmor +To: David Bremner , Notmuch Mail +Subject: Re: [PATCH v4 7/7] complete + ghost-on-removal-when-shared-thread-exists +In-Reply-To: <871t6f3tng.fsf@zancas.localnet> +References: <1459445693-3900-1-git-send-email-dkg@fifthhorseman.net> + <1460166892-29721-1-git-send-email-dkg@fifthhorseman.net> + <1460166892-29721-7-git-send-email-dkg@fifthhorseman.net> + <871t6f3tng.fsf@zancas.localnet> +User-Agent: Notmuch/0.21+124~gbf604e9 (http://notmuchmail.org) Emacs/24.5.1 + (x86_64-pc-linux-gnu) +Date: Sat, 09 Apr 2016 14:55:29 -0400 +Message-ID: <87shyuvcgu.fsf@alice.fifthhorseman.net> +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.20 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sat, 09 Apr 2016 18:55:50 -0000 + +On Sat 2016-04-09 07:31:47 -0400, David Bremner wrote: +> Daniel Kahn Gillmor writes: +> +> +>> + status = _notmuch_message_delete (message); +>> + if (status) /* we'll report the last failure we see; +>> + * if there is more than one failure, we +>> + * forget about previous ones */ +>> + last_error = status; +> +> I was initially worried/paranoid that there might be some risk of data +> loss by continuing deleting after the first bad status; that doesn't +> seem to be the case, but there doesn't seem to be much advantage in +> continuing either, since the only error currently returned from +> _notmuch_message_delete is from _notmuch_database_ensure_writable, +> which seems likely to persist. So perhaps exiting the loop on the +> first error might be less confusing. + +At the moment, that's the only possible error, but maybe there will be +more errors as notmuch grows/changes in the future? I figure we should +try once to delete each message we know we want to delete, regardless of +the success in deleting other message. So i'm inclined to keep it as-is, +but if someone wants to prepare a patch for the other direction i +wouldn't object strongly. + +> Other than that, and my bug in ghost-report, the series looks good to +> me. + +cool! do you need another rev of the series from me, or is that +something you're up for applying directly? + + --dkg -- 2.26.2