From bf2c7f2298840c4b7292114d60a0568a48d6abe0 Mon Sep 17 00:00:00 2001 From: joey Date: Sat, 17 Mar 2007 22:05:15 +0000 Subject: [PATCH] response --- doc/bugs/newfile-test.mdwn | 5 ++++- doc/discussion.mdwn | 1 - 2 files changed, 4 insertions(+), 2 deletions(-) delete mode 100644 doc/discussion.mdwn diff --git a/doc/bugs/newfile-test.mdwn b/doc/bugs/newfile-test.mdwn index b5e7428bd..29a09bfbf 100644 --- a/doc/bugs/newfile-test.mdwn +++ b/doc/bugs/newfile-test.mdwn @@ -6,4 +6,7 @@ The CGI tries to decide whether an user is trying to edit a new file or not with Assume the script is called like this `http://example.com/ikiwiki.cgi?page=discussion&from=some-page&do=create`. The `if (exists $pagesources{$page}) {` test determines whether there's a file called `$config{srcdir}/discussion`. Most installs won't have a `$config{srcdir}/discussion` page, so this test will fail causing the else clause to be executed. In this case, the else clause results in `$file` being set to `discussion.mdwn`. Thus, on typical installs `value => ! -e "$config{srcdir}/$file",` always succeeds, which results in the expected behaviour, albeit for the wrong reasons. Similarly, the ` $form->field(name => "rcsinfo", value => rcs_prepedit($file)` line is also meaningless because `$file` isn't what we think it is. -(To confirm that this wasn't just a result of my imagination, I created [[/discussion]] on this site; feel free to delete it now.) \ No newline at end of file +(To confirm that this wasn't just a result of my imagination, I created [[/discussion]] on this site; feel free to delete it now.) + +> I always find bug reports more comprehansible if they describe actual +> buggy behavior, which you've not done. Could you do so? Thanks. --[[Joey]] diff --git a/doc/discussion.mdwn b/doc/discussion.mdwn deleted file mode 100644 index 0519ecba6..000000000 --- a/doc/discussion.mdwn +++ /dev/null @@ -1 +0,0 @@ - \ No newline at end of file -- 2.26.2