From bc85726b244a4e73e0f2822997c55d6279c67f67 Mon Sep 17 00:00:00 2001 From: Tomi Ollila Date: Sat, 11 Jan 2014 12:22:52 +0200 Subject: [PATCH] Re: [PATCH 1/2] cli: clean up exit status code returned by the cli commands --- 3a/541d1ad814b83c3f72a3f3cc954babccd4e4b1 | 76 +++++++++++++++++++++++ 1 file changed, 76 insertions(+) create mode 100644 3a/541d1ad814b83c3f72a3f3cc954babccd4e4b1 diff --git a/3a/541d1ad814b83c3f72a3f3cc954babccd4e4b1 b/3a/541d1ad814b83c3f72a3f3cc954babccd4e4b1 new file mode 100644 index 000000000..de5848930 --- /dev/null +++ b/3a/541d1ad814b83c3f72a3f3cc954babccd4e4b1 @@ -0,0 +1,76 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 17F54431FC3 + for ; Sat, 11 Jan 2014 02:23:05 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id lD-4Bb51g46x for ; + Sat, 11 Jan 2014 02:22:57 -0800 (PST) +Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) + by olra.theworths.org (Postfix) with ESMTP id 06D00431FC0 + for ; Sat, 11 Jan 2014 02:22:57 -0800 (PST) +Received: from guru.guru-group.fi (localhost [IPv6:::1]) + by guru.guru-group.fi (Postfix) with ESMTP id A2B2910005E; + Sat, 11 Jan 2014 12:22:52 +0200 (EET) +From: Tomi Ollila +To: Jani Nikula , notmuch@notmuchmail.org +Subject: Re: [PATCH 1/2] cli: clean up exit status code returned by the cli + commands +In-Reply-To: <1389389334-24138-1-git-send-email-jani@nikula.org> +References: <1389389334-24138-1-git-send-email-jani@nikula.org> +User-Agent: Notmuch/0.17+23~ga575e35 (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-unknown-linux-gnu) +X-Face: HhBM'cA~ +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sat, 11 Jan 2014 10:23:05 -0000 + +On Fri, Jan 10 2014, Jani Nikula wrote: + +> Apart from the status codes for format mismatches, the non-zero exit +> status codes have been arbitrary. Make the cli consistently return +> either EXIT_SUCCESS or EXIT_FAILURE. +> --- + +These 2 patches LGTM. + +Tomi + + +> notmuch-compact.c | 6 +++--- +> notmuch-config.c | 23 ++++++++++++++--------- +> notmuch-count.c | 16 +++++++--------- +> notmuch-dump.c | 21 +++++++++------------ +> notmuch-insert.c | 25 +++++++++++-------------- +> notmuch-new.c | 18 ++++++++---------- +> notmuch-reply.c | 20 +++++++++----------- +> notmuch-restore.c | 23 +++++++++-------------- +> notmuch-search.c | 18 ++++++++---------- +> notmuch-setup.c | 15 +++++++-------- +> notmuch-show.c | 18 ++++++++---------- +> notmuch-tag.c | 22 +++++++++++----------- +> notmuch.c | 43 ++++++++++++++++++++++++++++--------------- -- 2.26.2