From bb8ecf878e3c924ae5337aaec11b5885a77272d8 Mon Sep 17 00:00:00 2001 From: David Bremner Date: Mon, 9 Sep 2013 22:52:07 +2100 Subject: [PATCH] Re: [PATCH v2 1/1] notmuch-mutt: Fix tagging issues --- fb/01ccfbfc2ae87f317c525bb828873b6b9c8a17 | 72 +++++++++++++++++++++++ 1 file changed, 72 insertions(+) create mode 100644 fb/01ccfbfc2ae87f317c525bb828873b6b9c8a17 diff --git a/fb/01ccfbfc2ae87f317c525bb828873b6b9c8a17 b/fb/01ccfbfc2ae87f317c525bb828873b6b9c8a17 new file mode 100644 index 000000000..7a2fd8388 --- /dev/null +++ b/fb/01ccfbfc2ae87f317c525bb828873b6b9c8a17 @@ -0,0 +1,72 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 91B21431FAF + for ; Sun, 8 Sep 2013 18:52:20 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id GsRXALngl7cW for ; + Sun, 8 Sep 2013 18:52:16 -0700 (PDT) +Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155]) + (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id A05A4431FAE + for ; Sun, 8 Sep 2013 18:52:16 -0700 (PDT) +Received: from remotemail by yantan.tethera.net with local (Exim 4.80) + (envelope-from ) + id 1VIqeA-0000WH-SK; Sun, 08 Sep 2013 22:52:10 -0300 +Received: (nullmailer pid 6334 invoked by uid 1000); Mon, 09 Sep 2013 + 01:52:07 -0000 +From: David Bremner +To: "Kevin J. McCarthy" , notmuch@notmuchmail.org +Subject: Re: [PATCH v2 1/1] notmuch-mutt: Fix tagging issues +In-Reply-To: <20130907170757.GA407@zaogao.lan> +References: <20130906221520.GC4226@zaogao.lan> + <20130907155748.GD4226@zaogao.lan> + <20130907170757.GA407@zaogao.lan> +User-Agent: Notmuch/0.16+37~g9701e9c (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-pc-linux-gnu) +Date: Sun, 08 Sep 2013 22:52:07 -0300 +Message-ID: <87sixe3goo.fsf@zancas.localnet> +MIME-Version: 1.0 +Content-Type: text/plain +Cc: Tomi Ollila , Stefano Zacchiroli +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Mon, 09 Sep 2013 01:52:20 -0000 + +"Kevin J. McCarthy" writes: + +> This patch fixes three issues with "notmuch-mutt tag": +> +> 1. The message_id was not shell quoted. +> Thanks to Jason Miller for the bug report and patch. +> +> 2. The tags passed into tag_action() were not being properly quoted. +> The "join before shell_quote" was combining multiple tags into a +> single argument to notmuch tag: '+one -two -three' instead of +> '+one' '-two' '-three'. +> +> 3. A "--" was added between the tags and search-term as shown in the +> current notmuch-tag man page. + +pushed. + +d -- 2.26.2