From bb27286644a350c1306c9d8e37833c9c9a5de769 Mon Sep 17 00:00:00 2001 From: David Bremner Date: Sun, 18 May 2014 06:46:08 +0900 Subject: [PATCH] Re: [PATCH] notmuch-dump: use fsync instead of fdatasync --- 36/046f82f3a730a40ad1a2f76bf619548cf11489 | 62 +++++++++++++++++++++++ 1 file changed, 62 insertions(+) create mode 100644 36/046f82f3a730a40ad1a2f76bf619548cf11489 diff --git a/36/046f82f3a730a40ad1a2f76bf619548cf11489 b/36/046f82f3a730a40ad1a2f76bf619548cf11489 new file mode 100644 index 000000000..90bd35f57 --- /dev/null +++ b/36/046f82f3a730a40ad1a2f76bf619548cf11489 @@ -0,0 +1,62 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 4B10D431FBF + for ; Sat, 17 May 2014 14:47:09 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id tnMuft7KgqEE for ; + Sat, 17 May 2014 14:47:02 -0700 (PDT) +Received: from mx.xen14.node3324.gplhost.com (gitolite.debian.net + [87.98.215.224]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 318B3431FBC + for ; Sat, 17 May 2014 14:47:02 -0700 (PDT) +Received: from remotemail by mx.xen14.node3324.gplhost.com with local (Exim + 4.72) (envelope-from ) + id 1WlmR4-00054Z-Ox; Sat, 17 May 2014 21:46:30 +0000 +Received: (nullmailer pid 19463 invoked by uid 1000); Sat, 17 May 2014 + 21:46:08 -0000 +From: David Bremner +To: notmuch@notmuchmail.org +Subject: Re: [PATCH] notmuch-dump: use fsync instead of fdatasync +In-Reply-To: <1399550227-18488-1-git-send-email-david@tethera.net> +References: <20140507171835.GA27619@mit.edu> + <1399550227-18488-1-git-send-email-david@tethera.net> +User-Agent: Notmuch/0.18 (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-pc-linux-gnu) +Date: Sun, 18 May 2014 06:46:08 +0900 +Message-ID: <87vbt49izj.fsf@maritornes.cs.unb.ca> +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sat, 17 May 2014 21:47:09 -0000 + +David Bremner writes: + +> Since the file size will have changed, there is no performance benefit +> to calling fdatasync. Somewhat surprisingly, using fdatasync +> apparently causes portability problems on FreeBSD. +> --- + +pushed to release and master. + +d -- 2.26.2