From b905114efe127cd62bf6f570ca001bbc2822c015 Mon Sep 17 00:00:00 2001 From: Tomi Ollila Date: Tue, 4 Feb 2014 12:31:36 +0200 Subject: [PATCH] Re: [PATCH 2/2] emacs: Prefer Content-Description over filename for part buttons --- 7f/d8f0f82301e1ef92df8dbb2449a12cd3a5efa8 | 86 +++++++++++++++++++++++ 1 file changed, 86 insertions(+) create mode 100644 7f/d8f0f82301e1ef92df8dbb2449a12cd3a5efa8 diff --git a/7f/d8f0f82301e1ef92df8dbb2449a12cd3a5efa8 b/7f/d8f0f82301e1ef92df8dbb2449a12cd3a5efa8 new file mode 100644 index 000000000..12b09698f --- /dev/null +++ b/7f/d8f0f82301e1ef92df8dbb2449a12cd3a5efa8 @@ -0,0 +1,86 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 6CC88431FBC + for ; Tue, 4 Feb 2014 02:31:50 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id 9Ed5XVpVfoQc for ; + Tue, 4 Feb 2014 02:31:44 -0800 (PST) +Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) + by olra.theworths.org (Postfix) with ESMTP id 8DB3A431FAF + for ; Tue, 4 Feb 2014 02:31:44 -0800 (PST) +Received: from guru.guru-group.fi (localhost [IPv6:::1]) + by guru.guru-group.fi (Postfix) with ESMTP id 9BBEF100033; + Tue, 4 Feb 2014 12:31:36 +0200 (EET) +From: Tomi Ollila +To: "W. Trevor King" +Subject: Re: [PATCH 2/2] emacs: Prefer Content-Description over filename for + part buttons +In-Reply-To: <20140204001430.GP14197@odin.tremily.us> +References: <877g9chbay.fsf@qmul.ac.uk> + + <27be295875a7df782a83c9a2c09d06f9d321fe9e.1391423201.git.wking@tremily.us> + <20140204001430.GP14197@odin.tremily.us> +User-Agent: Notmuch/0.17+55~g4397960 (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-unknown-linux-gnu) +X-Face: HhBM'cA~ +MIME-Version: 1.0 +Content-Type: text/plain +Cc: notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Tue, 04 Feb 2014 10:31:50 -0000 + +On Tue, Feb 04 2014, "W. Trevor King" wrote: + +> On Mon, Feb 03, 2014 at 10:44:39PM +0200, Tomi Ollila wrote: +>> having notmuch patch email as expected test output feels a bit +>> confusing to me -- especially as 'git grep' may catch some of the +>> (possibly future-outdated) content... +> +> There were two very similar patches with filename attachments in the +> corpus, so I used them for the tests ;). I can convert that test to +> use emacs_fcc_message or some other auto-generated content if you'd +> prefer. + +You're right; corpus seems to be full of notmuch patch emails... + + +... and (although?) (just noticed)... + +$ grep '^ *[+-].*\' test/* test/*/* +test/emacs.expected-output/attachment:+ if (pw_buf_size == -1) +pw_buf_size = 64; +test/emacs.expected-output/attachment:+ if (pw_buf_size == -1) +pw_buf_size = 64; + +... I am not giving much resistance to keep the patch as it is :D + +> +> Cheers, +> Trevor +> + +Tomi -- 2.26.2