From b898440e35aa96cd50c74b13d26d5924d2d708ed Mon Sep 17 00:00:00 2001 From: Zac Medico Date: Wed, 14 Dec 2011 01:17:16 -0800 Subject: [PATCH] tests/locks: save/restore global env state This ensures that global __PORTAGE_TEST_HARDLINK_LOCKS overrides work correctly for all tests. --- pym/portage/tests/locks/test_asynchronous_lock.py | 12 ++++++++++++ pym/portage/tests/locks/test_lock_nonblock.py | 3 +++ 2 files changed, 15 insertions(+) diff --git a/pym/portage/tests/locks/test_asynchronous_lock.py b/pym/portage/tests/locks/test_asynchronous_lock.py index c896cb45c..49dd10ec4 100644 --- a/pym/portage/tests/locks/test_asynchronous_lock.py +++ b/pym/portage/tests/locks/test_asynchronous_lock.py @@ -43,11 +43,14 @@ class AsynchronousLockTestCase(TestCase): self._testAsynchronousLock() def testAsynchronousLockHardlink(self): + prev_state = os.environ.pop("__PORTAGE_TEST_HARDLINK_LOCKS", None) os.environ["__PORTAGE_TEST_HARDLINK_LOCKS"] = "1" try: self._testAsynchronousLock() finally: os.environ.pop("__PORTAGE_TEST_HARDLINK_LOCKS", None) + if prev_state is not None: + os.environ["__PORTAGE_TEST_HARDLINK_LOCKS"] = prev_state def _testAsynchronousLockWait(self): scheduler = PollScheduler().sched_iface @@ -81,11 +84,14 @@ class AsynchronousLockTestCase(TestCase): self._testAsynchronousLockWait() def testAsynchronousLockWaitHardlink(self): + prev_state = os.environ.pop("__PORTAGE_TEST_HARDLINK_LOCKS", None) os.environ["__PORTAGE_TEST_HARDLINK_LOCKS"] = "1" try: self._testAsynchronousLockWait() finally: os.environ.pop("__PORTAGE_TEST_HARDLINK_LOCKS", None) + if prev_state is not None: + os.environ["__PORTAGE_TEST_HARDLINK_LOCKS"] = prev_state def _testAsynchronousLockWaitCancel(self): scheduler = PollScheduler().sched_iface @@ -116,11 +122,14 @@ class AsynchronousLockTestCase(TestCase): self._testAsynchronousLockWaitCancel() def testAsynchronousLockWaitCancelHardlink(self): + prev_state = os.environ.pop("__PORTAGE_TEST_HARDLINK_LOCKS", None) os.environ["__PORTAGE_TEST_HARDLINK_LOCKS"] = "1" try: self._testAsynchronousLockWaitCancel() finally: os.environ.pop("__PORTAGE_TEST_HARDLINK_LOCKS", None) + if prev_state is not None: + os.environ["__PORTAGE_TEST_HARDLINK_LOCKS"] = prev_state def _testAsynchronousLockWaitKill(self): scheduler = PollScheduler().sched_iface @@ -157,8 +166,11 @@ class AsynchronousLockTestCase(TestCase): self._testAsynchronousLockWaitKill() def testAsynchronousLockWaitKillHardlink(self): + prev_state = os.environ.pop("__PORTAGE_TEST_HARDLINK_LOCKS", None) os.environ["__PORTAGE_TEST_HARDLINK_LOCKS"] = "1" try: self._testAsynchronousLockWaitKill() finally: os.environ.pop("__PORTAGE_TEST_HARDLINK_LOCKS", None) + if prev_state is not None: + os.environ["__PORTAGE_TEST_HARDLINK_LOCKS"] = prev_state diff --git a/pym/portage/tests/locks/test_lock_nonblock.py b/pym/portage/tests/locks/test_lock_nonblock.py index 914084ca7..17f854dbe 100644 --- a/pym/portage/tests/locks/test_lock_nonblock.py +++ b/pym/portage/tests/locks/test_lock_nonblock.py @@ -48,9 +48,12 @@ class LockNonblockTestCase(TestCase): self._testLockNonblock() def testLockNonblockHardlink(self): + prev_state = os.environ.pop("__PORTAGE_TEST_HARDLINK_LOCKS", None) os.environ["__PORTAGE_TEST_HARDLINK_LOCKS"] = "1" try: self._testLockNonblock() finally: os.environ.pop("__PORTAGE_TEST_HARDLINK_LOCKS", None) + if prev_state is not None: + os.environ["__PORTAGE_TEST_HARDLINK_LOCKS"] = prev_state -- 2.26.2