From b7a7e591b11dda04f36d31755338e51001796ab8 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Amadeusz=20=C5=BBo=C5=82nowski?= Date: Fri, 25 Nov 2011 16:12:24 +0100 Subject: [PATCH] Re: [PATCH 1/2] Build symbol-test with make instead of hardcoding in symbol-hiding. --- 6e/d17f9323bbda50e08a9f6992f43c317be6cc79 | 130 ++++++++++++++++++++++ 1 file changed, 130 insertions(+) create mode 100644 6e/d17f9323bbda50e08a9f6992f43c317be6cc79 diff --git a/6e/d17f9323bbda50e08a9f6992f43c317be6cc79 b/6e/d17f9323bbda50e08a9f6992f43c317be6cc79 new file mode 100644 index 000000000..c76ea5792 --- /dev/null +++ b/6e/d17f9323bbda50e08a9f6992f43c317be6cc79 @@ -0,0 +1,130 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id B5643431FD0 + for ; Fri, 25 Nov 2011 07:12:30 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id b4kYE-tvcvNR for ; + Fri, 25 Nov 2011 07:12:30 -0800 (PST) +Received: from mail-bw0-f53.google.com (mail-bw0-f53.google.com + [209.85.214.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id EE146431FB6 + for ; Fri, 25 Nov 2011 07:12:29 -0800 (PST) +Received: by bkaq10 with SMTP id q10so4872190bka.26 + for ; Fri, 25 Nov 2011 07:12:28 -0800 (PST) +Received: by 10.204.8.77 with SMTP id g13mr32869970bkg.89.1322233948092; + Fri, 25 Nov 2011 07:12:28 -0800 (PST) +Received: from localhost (abtw56.neoplus.adsl.tpnet.pl. [83.8.168.56]) + by mx.google.com with ESMTPS id e20sm28864703fab.2.2011.11.25.07.12.25 + (version=TLSv1/SSLv3 cipher=OTHER); + Fri, 25 Nov 2011 07:12:26 -0800 (PST) +From: =?utf-8?q?Amadeusz_=C5=BBo=C5=82nowski?= +To: David Bremner +Subject: Re: [PATCH 1/2] Build symbol-test with make instead of hardcoding in + symbol-hiding. +In-reply-to: <878vn4bbf7.fsf@convex-new.cs.unb.ca> +References: <1322218492-8300-1-git-send-email-aidecoe@aidecoe.name> + <878vn4bbf7.fsf@convex-new.cs.unb.ca> +Date: Fri, 25 Nov 2011 16:12:24 +0100 +Message-Id: <1322233411-sup-6651@ittemni> +User-Agent: Sup/git +Content-Transfer-Encoding: 8bit +MIME-Version: 1.0 +Content-Type: multipart/signed; protocol="application/pgp-signature"; + boundary="=-1322233944-445180-28641-4206-1-=" +Cc: notmuch +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Fri, 25 Nov 2011 15:12:30 -0000 + + +--=-1322233944-445180-28641-4206-1-= +Content-Type: text/plain; charset=UTF-8 +Content-Transfer-Encoding: quoted-printable + +Excerpts from David Bremner's message of 2011-11-25 14:04:44 +0100: +> On Fri, 25 Nov 2011 11:54:51 +0100, Amadeusz =C5=BBo=C5=82nowski wrote: +> > = + +> > +$(dir)/symbol-test: $(dir)/symbol-test.o +> > + $(call quiet,CC) $^ -o $@ -Llib -lnotmuch -lxapian +> = + +> I'm a bit surprised no -I is neaded here. Is that taken care in the CC +> call? + +-I is for headers which are not used when linking. symbol-test.o is +compiled according to rule defined earlier in some parent Makefile. + + +> > .PHONY: test check +> > -test: all $(dir)/smtp-dummy +> > +test: all $(dir)/smtp-dummy $(dir)/symbol-test +> > @${dir}/notmuch-test $(OPTIONS) +> = + +> The instructions were already wrong, but maybe they should be updated t= +o +> point out that calling the test scripts directly requires smtp-dummy an= +d +> symbol-test already be built. Or maybe the tests should check for these= + +> binaries as pre-reqs along with emacs, gpg, etc... = + +> = + +> > + -e "/^(emacs.expected-output|smtp-dummy|smtp-dummy.c|test-ver= +bose|symbol-test.cc|symbol-test|symbol-test.o)/d" \ +> = + +> I wonder if this should be shortened (and made a bit sloppier) with the= + +> use of regexes. + +Thanks it's so straightforward. I found this line quickly without deep +analysis of all test-framework. :-) It could only be made more flexible +- put list of this files into some separate text file. But that's +subject for another patch. Purpose of this one is to make building out +of tree working. + + +-- +Amadeusz =C5=BBo=C5=82nowski + +--=-1322233944-445180-28641-4206-1-= +Content-Disposition: attachment; filename="signature.asc" +Content-Type: application/pgp-signature; name="signature.asc" + +-----BEGIN PGP SIGNATURE----- +Version: GnuPG v2.0.18 (GNU/Linux) + +iQEcBAEBAgAGBQJOz7BYAAoJEPATRTHh2/q1sJUIAIBRHA27PddyBEm/+xYFQp+m +3m6AkOBNtxjZ11DOxFD5Yva98De3/mmwnvn0xCj9DcRT+lXZamxE1BU22TouxMRx +J7FFuUVX1DP9EJPnGfc3P0ZKlcEGWKKLSSL0lt38IoWEK4mmUY/XjTSuhh8B5v/4 ++0T7pWeU/TBS0U7pEr/z2AtzODq9PMP771BzHGzrevIeDul3RJ390g55h5Vlo5oa +jYELaqPSx5C2tuLzBWJ0LVhDGVRtp/YpQw973ltKJz4vyPgU87h4AjNYvj8CYj/B +qsX15qljqbNnGK8WeRKH2poKLCVFrG9OpXvhYX4UWBuXuRxiVqBil+eFxfLVR0E= +=d64X +-----END PGP SIGNATURE----- + +--=-1322233944-445180-28641-4206-1-=-- -- 2.26.2