From b505a29c7025578046628ba6b12bf536744c8616 Mon Sep 17 00:00:00 2001 From: Mark Walters Date: Sat, 18 Jan 2014 13:09:19 +0000 Subject: [PATCH] Re: [PATCH 1/2] cli: clean up exit status code returned by the cli commands --- b6/93e7f9642c7189d5727cf44045bdcddf6de765 | 110 ++++++++++++++++++++++ 1 file changed, 110 insertions(+) create mode 100644 b6/93e7f9642c7189d5727cf44045bdcddf6de765 diff --git a/b6/93e7f9642c7189d5727cf44045bdcddf6de765 b/b6/93e7f9642c7189d5727cf44045bdcddf6de765 new file mode 100644 index 000000000..5733131a2 --- /dev/null +++ b/b6/93e7f9642c7189d5727cf44045bdcddf6de765 @@ -0,0 +1,110 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 1AA72431FBD + for ; Sat, 18 Jan 2014 05:09:32 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -1.098 +X-Spam-Level: +X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5 + tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001, + NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id VVOWNWp3uIgB for ; + Sat, 18 Jan 2014 05:09:24 -0800 (PST) +Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6]) + (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id DDCE3431FBC + for ; Sat, 18 Jan 2014 05:09:23 -0800 (PST) +Received: from smtp.qmul.ac.uk ([138.37.6.40]) + by mail2.qmul.ac.uk with esmtp (Exim 4.71) + (envelope-from ) + id 1W4VeL-0007Dy-8G; Sat, 18 Jan 2014 13:09:21 +0000 +Received: from 93-97-24-31.zone5.bethere.co.uk ([93.97.24.31] helo=localhost) + by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.71) + (envelope-from ) + id 1W4VeK-0002fd-SH; Sat, 18 Jan 2014 13:09:21 +0000 +From: Mark Walters +To: Tomi Ollila , Jani Nikula , + notmuch@notmuchmail.org +Subject: Re: [PATCH 1/2] cli: clean up exit status code returned by the cli + commands +In-Reply-To: +References: <1389389334-24138-1-git-send-email-jani@nikula.org> + +User-Agent: Notmuch/0.15.2+484~gfb59956 (http://notmuchmail.org) Emacs/23.4.1 + (x86_64-pc-linux-gnu) +Date: Sat, 18 Jan 2014 13:09:19 +0000 +Message-ID: <87ob39cu80.fsf@qmul.ac.uk> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-Sender-Host-Address: 93.97.24.31 +X-QM-Geographic: According to ripencc, + this message was delivered by a machine in Britain (UK) (GB). +X-QM-SPAM-Info: Sender has good ham record. :) +X-QM-Body-MD5: 761b087ee2e9a62d8b74b8b5a5e6faaa (of first 20000 bytes) +X-SpamAssassin-Score: 0.0 +X-SpamAssassin-SpamBar: / +X-SpamAssassin-Report: The QM spam filters have analysed this message to + determine if it is + spam. We require at least 5.0 points to mark a message as spam. + This message scored 0.0 points. Summary of the scoring: + * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail + provider * (markwalters1009[at]gmail.com) + * 0.0 AWL AWL: From: address is in the auto white-list +X-QM-Scan-Virus: ClamAV says the message is clean +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sat, 18 Jan 2014 13:09:32 -0000 + + +These LGTM too. + +Best wishes + +Mark + +On Sat, 11 Jan 2014, Tomi Ollila wrote: +> On Fri, Jan 10 2014, Jani Nikula wrote: +> +>> Apart from the status codes for format mismatches, the non-zero exit +>> status codes have been arbitrary. Make the cli consistently return +>> either EXIT_SUCCESS or EXIT_FAILURE. +>> --- +> +> These 2 patches LGTM. +> +> Tomi +> +> +>> notmuch-compact.c | 6 +++--- +>> notmuch-config.c | 23 ++++++++++++++--------- +>> notmuch-count.c | 16 +++++++--------- +>> notmuch-dump.c | 21 +++++++++------------ +>> notmuch-insert.c | 25 +++++++++++-------------- +>> notmuch-new.c | 18 ++++++++---------- +>> notmuch-reply.c | 20 +++++++++----------- +>> notmuch-restore.c | 23 +++++++++-------------- +>> notmuch-search.c | 18 ++++++++---------- +>> notmuch-setup.c | 15 +++++++-------- +>> notmuch-show.c | 18 ++++++++---------- +>> notmuch-tag.c | 22 +++++++++++----------- +>> notmuch.c | 43 ++++++++++++++++++++++++++++--------------- +> _______________________________________________ +> notmuch mailing list +> notmuch@notmuchmail.org +> http://notmuchmail.org/mailman/listinfo/notmuch -- 2.26.2