From b2d3007fbb84fa476e3b072c5506cfdf8de0f458 Mon Sep 17 00:00:00 2001 From: Greg Hudson Date: Thu, 22 Apr 2010 03:44:44 +0000 Subject: [PATCH] Eliminate a non-useful NULL check in the KDC's dispatch() function. If process_as_req or process_tgs_req return successfully, they will always fill in *response. (If they didn't, the subsequence (*response)->length check would crash anyway.) git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23922 dc483132-0cff-0310-8789-dd5450dbe970 --- src/kdc/dispatch.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/kdc/dispatch.c b/src/kdc/dispatch.c index 207fa390a..63ff3b38d 100644 --- a/src/kdc/dispatch.c +++ b/src/kdc/dispatch.c @@ -111,7 +111,7 @@ dispatch(void *cb, struct sockaddr *local_saddr, const krb5_fulladdr *from, retval = KRB5KRB_AP_ERR_MSG_TYPE; #ifndef NOCACHE /* put the response into the lookaside buffer */ - if (!retval && *response != NULL) + if (!retval) kdc_insert_lookaside(pkt, *response); #endif -- 2.26.2