From b1090cb75c828328fcbf25cc94b7a634d1536b5a Mon Sep 17 00:00:00 2001 From: Mark Walters Date: Tue, 9 Feb 2016 21:04:20 +0000 Subject: [PATCH] Re: [PATCH v5 3/3] emacs: Bind filter in search to 'l' --- 42/f3222d954e2fde26fd6e84c77b9b524697c3dd | 138 ++++++++++++++++++++++ 1 file changed, 138 insertions(+) create mode 100644 42/f3222d954e2fde26fd6e84c77b9b524697c3dd diff --git a/42/f3222d954e2fde26fd6e84c77b9b524697c3dd b/42/f3222d954e2fde26fd6e84c77b9b524697c3dd new file mode 100644 index 000000000..587d80ffc --- /dev/null +++ b/42/f3222d954e2fde26fd6e84c77b9b524697c3dd @@ -0,0 +1,138 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by arlo.cworth.org (Postfix) with ESMTP id 01FAB6DE17AC + for ; Tue, 9 Feb 2016 13:04:26 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at cworth.org +X-Spam-Flag: NO +X-Spam-Score: -0.219 +X-Spam-Level: +X-Spam-Status: No, score=-0.219 tagged_above=-999 required=5 tests=[AWL=0.351, + DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, + FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, + RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001] + autolearn=disabled +Received: from arlo.cworth.org ([127.0.0.1]) + by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id ujzQ2zQ6OYs2 for ; + Tue, 9 Feb 2016 13:04:24 -0800 (PST) +Received: from mail-wm0-f68.google.com (mail-wm0-f68.google.com + [74.125.82.68]) by arlo.cworth.org (Postfix) with ESMTPS id DB3EA6DE17A4 for + ; Tue, 9 Feb 2016 13:04:23 -0800 (PST) +Received: by mail-wm0-f68.google.com with SMTP id p63so140143wmp.1 + for ; Tue, 09 Feb 2016 13:04:23 -0800 (PST) +DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; + h=from:to:subject:in-reply-to:references:user-agent:date:message-id + :mime-version:content-type; + bh=Yg/MNWf128V9TepUeMrAjzdAGBzj+0SJWDyGjSVQNAw=; + b=sd+lZQl1eD9G3tRZxh3d6uakFUvLuUFRz5BbyS8OSTcCEvQ57z7DV4Q6tpgUYOu0mP + mr8zuU10/IJS7osDGvmVi3pi25QouxygxVQRyOXsFGGuWS9opI0qGAMwlSQAVihdvEpx + bag1ypboIPk+thjSRvLRm6DmE4/nHYUZkJ+KrYxXlCbc9s1eexyCZBAtRuylp2RbP6r+ + 8NnUbFheuSJmcIlzCcI9Fxlp6xaBdq0bHFUO94m+m6L8XUURBAdAcTunhkmesM/QFxAc + a0RkepNf+4bFlyARqgRbTr7CG7v/o/NXLIUF8riFNp96YeydZtt+IrIfEfhIoeJ3H4FX + YENg== +X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; + d=1e100.net; s=20130820; + h=x-gm-message-state:from:to:subject:in-reply-to:references + :user-agent:date:message-id:mime-version:content-type; + bh=Yg/MNWf128V9TepUeMrAjzdAGBzj+0SJWDyGjSVQNAw=; + b=hf/q47tDrHg8KQZaQesJLALhjMkr2e6AuHsF4K+5P6479qvWpj3do/PxYuGZHtDJZ2 + Tcpv4Tl9+nBW71dvmucWPeM7DLPnJKCUJa4kjzHvdPlwzZhI1aNC1xTBU3fL9qo5H/tu + l6DYvPiBfBAftJkcgQ5MEHQ312YSfDZmLxBWQsN8e1qlS71BhJycm/LRKBpj0mm4wMW3 + +ZzvMqfUUQ3Xv9Rs4aUHXhkh5aXacT+JI2gTdEbDXRFaaegTbR0IylHvVPlfnrW8LSHV + MEz2BMDOIWbrPJIlrfq5yj1rB9765CeYpdJ04iQd0tzxZAqBU2beji+lly5kvyTxtP9D + mDMw== +X-Gm-Message-State: + AG10YOQUsQQTHktvQd9Uz91LMEsxKQHJs9odqZEIHcHZsOqtstMG4gxGOJeRUX3N5KUpMw== +X-Received: by 10.194.62.179 with SMTP id z19mr5512753wjr.96.1455051862412; + Tue, 09 Feb 2016 13:04:22 -0800 (PST) +Received: from localhost (5751dfa2.skybroadband.com. [87.81.223.162]) + by smtp.gmail.com with ESMTPSA id gt7sm36463789wjc.1.2016.02.09.13.04.21 + (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); + Tue, 09 Feb 2016 13:04:21 -0800 (PST) +From: Mark Walters +To: David Edmondson , notmuch@notmuchmail.org +Subject: Re: [PATCH v5 3/3] emacs: Bind filter in search to 'l' +In-Reply-To: +References: <1434182890-8047-1-git-send-email-markwalters1009@gmail.com> + <1434182890-8047-4-git-send-email-markwalters1009@gmail.com> + +User-Agent: Notmuch/0.18.1+485~gca076ce (http://notmuchmail.org) Emacs/24.4.1 + (x86_64-pc-linux-gnu) +Date: Tue, 09 Feb 2016 21:04:20 +0000 +Message-ID: <87wpqd61ez.fsf@qmul.ac.uk> +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.20 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Tue, 09 Feb 2016 21:04:26 -0000 + + +On Tue, 09 Feb 2016, David Edmondson wrote: +> On Sat, Jun 13 2015, Mark Walters wrote: +>> Change the key binding for filter (or "limit") in search-mode. This +>> gives consistency with the new filter in show-mode, and frees 'f' for +>> forward-thread in the future. +> +> Is there a conclusion on this change? The patch itself seems obviously +> fine from a code perspective, at issue is more whether it's acceptable +> to change the key binding. +> +> The equivalent binding in notmuch-show mode is already "l", and I think +> that it makes sense to be consistent (i.e. the change should be +> applied). + +I broadly agree, particularly as it will free up f for forwarding a +thread in search view (which is easy to do on top of +id:1454931262-21362-1-git-send-email-dme@dme.org). + +It will be annoying in the short term to learn the change, but I don't +see a way round that. + +Best wishes + +Mark + + + + +> +>> --- +>> emacs/notmuch.el | 4 ++-- +>> 1 file changed, 2 insertions(+), 2 deletions(-) +>> +>> diff --git a/emacs/notmuch.el b/emacs/notmuch.el +>> index 6564816..06e3b94 100644 +>> --- a/emacs/notmuch.el +>> +++ b/emacs/notmuch.el +>> @@ -166,7 +166,7 @@ (defvar notmuch-search-mode-map +>> (define-key map "o" 'notmuch-search-toggle-order) +>> (define-key map "c" 'notmuch-search-stash-map) +>> (define-key map "t" 'notmuch-search-filter-by-tag) +>> - (define-key map "f" 'notmuch-search-filter) +>> + (define-key map "l" 'notmuch-search-filter) +>> (define-key map [mouse-1] 'notmuch-search-show-thread) +>> (define-key map "*" 'notmuch-search-tag-all) +>> (define-key map "a" 'notmuch-search-archive-thread) +>> @@ -983,7 +983,7 @@ (defun notmuch-search-toggle-order () +>> (notmuch-search-refresh-view)) +>> +>> (defun notmuch-search-filter (query) +>> - "Filter the current search results based on an additional query string. +>> + "Filter or LIMIT the current search results based on an additional query string. +>> +>> Runs a new search matching only messages that match both the +>> current search results AND the additional query string provided." +>> -- +>> 2.1.4 -- 2.26.2