From afd70ceacf522efeb64ea0cbf4626c7533e2c021 Mon Sep 17 00:00:00 2001 From: Zac Medico Date: Mon, 28 Feb 2011 12:37:22 -0800 Subject: [PATCH] repoman: variable.usedwithhelpers ignore quoted --- pym/repoman/checks.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/pym/repoman/checks.py b/pym/repoman/checks.py index 566984a51..200b542bb 100644 --- a/pym/repoman/checks.py +++ b/pym/repoman/checks.py @@ -333,7 +333,9 @@ class NoOffsetWithHelpers(LineCheck): helpers """ repoman_check_name = 'variable.usedwithhelpers' - re = re.compile(r'^[^#]*\b(dodir|dohard|exeinto|insinto|into)\s+"?\$\{?(D|ROOT|ED|EROOT|EPREFIX)\b.*') + # Ignore matches in quoted strings like this: + # elog "installed into ${ROOT}usr/share/php5/apc/." + re = re.compile(r'^[^#"\']*\b(dodir|dohard|exeinto|insinto|into)\s+"?\$\{?(D|ROOT|ED|EROOT|EPREFIX)\b.*') error = errors.NO_OFFSET_WITH_HELPERS class ImplicitRuntimeDeps(LineCheck): -- 2.26.2