From afce58d43a378e64fd0682cd3df515351a8a2646 Mon Sep 17 00:00:00 2001 From: Mark Walters Date: Thu, 19 Dec 2013 19:12:22 +0000 Subject: [PATCH] [PATCH 0/2] make tree use notmuch-tag-format-tags --- 38/c2e2fb9e85ac86d664064a06d379ce711642dd | 98 +++++++++++++++++++++++ 1 file changed, 98 insertions(+) create mode 100644 38/c2e2fb9e85ac86d664064a06d379ce711642dd diff --git a/38/c2e2fb9e85ac86d664064a06d379ce711642dd b/38/c2e2fb9e85ac86d664064a06d379ce711642dd new file mode 100644 index 000000000..e61b53971 --- /dev/null +++ b/38/c2e2fb9e85ac86d664064a06d379ce711642dd @@ -0,0 +1,98 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id F0514431FDC + for ; Thu, 19 Dec 2013 11:12:42 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 2.7 +X-Spam-Level: ** +X-Spam-Status: No, score=2.7 tagged_above=-999 required=5 + tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, + FREEMAIL_ENVFROM_END_DIGIT=1, FREEMAIL_FROM=0.001, + FREEMAIL_REPLY=2.499, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id ci8N1rQFFH4i for ; + Thu, 19 Dec 2013 11:12:35 -0800 (PST) +Received: from mail-wi0-f178.google.com (mail-wi0-f178.google.com + [209.85.212.178]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 43FA8431FC4 + for ; Thu, 19 Dec 2013 11:12:35 -0800 (PST) +Received: by mail-wi0-f178.google.com with SMTP id bz8so2690200wib.11 + for ; Thu, 19 Dec 2013 11:12:33 -0800 (PST) +DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; + h=from:to:cc:subject:date:message-id; + bh=vfYuWweqV6G+rkFwTiwFusAOdHKpx5iEXWITJlGsvqc=; + b=XLKM9IgL+rwtudpMavzm1Ku59fAXTh1S2fHI+ZthuaPrRJDoYng6DCg0U5/to8DeH2 + bRAGMNcD5TBZQ1+rDE4grBRqAZ9cDtGR3jMEgAJo+UI0kg9S36oQquzcTKsemmgtm9/Y + Fy2x8sw+W8rg60WaeKBuhw635vi7A5QmKGvjZwEfKD+O7SJ9wPZV1a5t/XurXCWW/l72 + aqvKISXgSz1ivbLFg40FxvPASBBRx1EgjwU71eaU/VMhERUOKzWT0JO/zs+zMEzqfWzB + 8WkxuP3jvdwld+81NL9lUUzmN/kIlzF3L87TN2xBFKOC5Yn50pFfwA5A/tdu+HD0dLS5 + +FiQ== +X-Received: by 10.194.174.36 with SMTP id bp4mr3205701wjc.7.1387480352603; + Thu, 19 Dec 2013 11:12:32 -0800 (PST) +Received: from localhost (93-97-24-31.zone5.bethere.co.uk. [93.97.24.31]) + by mx.google.com with ESMTPSA id ey3sm8002811wib.4.2013.12.19.11.12.30 + for + (version=TLSv1.2 cipher=RC4-SHA bits=128/128); + Thu, 19 Dec 2013 11:12:31 -0800 (PST) +From: Mark Walters +To: notmuch@notmuchmail.org +Subject: [PATCH 0/2] make tree use notmuch-tag-format-tags +Date: Thu, 19 Dec 2013 19:12:22 +0000 +Message-Id: <1387480344-14326-1-git-send-email-markwalters1009@gmail.com> +X-Mailer: git-send-email 1.7.9.1 +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Thu, 19 Dec 2013 19:12:43 -0000 + +My experiments with unread handling lead me to consider showing +added/deleted tags explicitly (eg deleted with strike-through and +added with underlining). The series +id:1387065197-15776-1-git-send-email-markwalters1009@gmail.com does +this by hooking into notmuch-tag-format-tags. + +Tree view does not use this functionality so did not get this +feature. This pair of patches makes tree use notmuch-tag-format-tags +so it can get all this extra, as well as the existing functionality +that notmuch-tag-format-tags provides (eg star symbols for flagged +messages) + +In doing so I discovered that tree separates the tags with ", " not +just " "; this would change when moving to notmuch-tag-format-tags so +do this trivial change first as it does require a large patch (160 +lines) to fix all the test expected outputs. + +Best wishes + +Mark + + +Mark Walters (2): + emacs: tree remove comma separator tags + emacs: tree: use tag-format-tags + + emacs/notmuch-tag.el | 17 ++-- + emacs/notmuch-tree.el | 8 +- + .../notmuch-tree-single-thread | 8 +- + test/tree.expected-output/notmuch-tree-tag-inbox | 104 ++++++++++---------- + .../notmuch-tree-tag-inbox-tagged | 104 ++++++++++---------- + .../notmuch-tree-tag-inbox-thread-tagged | 104 ++++++++++---------- + 6 files changed, 173 insertions(+), 172 deletions(-) + +-- +1.7.9.1 + -- 2.26.2