From afab4bc6e9844afe4d2d44b83e5c4a46e31d2b54 Mon Sep 17 00:00:00 2001 From: Tomi Ollila Date: Wed, 13 Nov 2013 19:02:45 +0200 Subject: [PATCH] [PATCH v2 3/5] compact: preserve backup database until compacted database is in place --- bd/934a041d1ed492696104cccae9b9fc0368bc17 | 132 ++++++++++++++++++++++ 1 file changed, 132 insertions(+) create mode 100644 bd/934a041d1ed492696104cccae9b9fc0368bc17 diff --git a/bd/934a041d1ed492696104cccae9b9fc0368bc17 b/bd/934a041d1ed492696104cccae9b9fc0368bc17 new file mode 100644 index 000000000..c8a81ee87 --- /dev/null +++ b/bd/934a041d1ed492696104cccae9b9fc0368bc17 @@ -0,0 +1,132 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 04F87431E82 + for ; Wed, 13 Nov 2013 09:03:03 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id cI-b-5us4uYx for ; + Wed, 13 Nov 2013 09:02:56 -0800 (PST) +Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) + by olra.theworths.org (Postfix) with ESMTP id 6D264431FD0 + for ; Wed, 13 Nov 2013 09:02:56 -0800 (PST) +Received: by guru.guru-group.fi (Postfix, from userid 501) + id 15DDD1000F3; Wed, 13 Nov 2013 19:02:52 +0200 (EET) +From: Tomi Ollila +To: notmuch@notmuchmail.org +Subject: [PATCH v2 3/5] compact: preserve backup database until compacted + database is in place +Date: Wed, 13 Nov 2013 19:02:45 +0200 +Message-Id: <1384362167-12740-4-git-send-email-tomi.ollila@iki.fi> +X-Mailer: git-send-email 1.8.0 +In-Reply-To: <1384362167-12740-1-git-send-email-tomi.ollila@iki.fi> +References: <1384362167-12740-1-git-send-email-tomi.ollila@iki.fi> +Cc: tomi.ollila@iki.fi +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Wed, 13 Nov 2013 17:03:03 -0000 + +It is less error prone and window of failure opportunity is smaller +if the old (backup) database is always renamed (instead of sometimes +rmtree'd) before new (compacted) database is put into its place. +Finally rmtree() old database in case old database backup is not kept. +--- + lib/database.cc | 42 +++++++++++++++++++++++++----------------- + 1 file changed, 25 insertions(+), 17 deletions(-) + +diff --git a/lib/database.cc b/lib/database.cc +index 3530cb6..ee09c5e 100644 +--- a/lib/database.cc ++++ b/lib/database.cc +@@ -873,6 +873,7 @@ notmuch_database_compact (const char *path, + notmuch_status_t ret = NOTMUCH_STATUS_SUCCESS; + notmuch_database_t *notmuch = NULL; + struct stat statbuf; ++ notmuch_bool_t keep_backup; + + local = talloc_new (NULL); + if (! local) +@@ -898,17 +899,25 @@ notmuch_database_compact (const char *path, + goto DONE; + } + +- if (backup_path != NULL) { +- if (stat (backup_path, &statbuf) != -1) { +- fprintf (stderr, "Backup path already exists: %s\n", backup_path); +- ret = NOTMUCH_STATUS_FILE_ERROR; +- goto DONE; +- } +- if (errno != ENOENT) { +- fprintf (stderr, "Unknown error while stat()ing backup path: %s\n", +- strerror (errno)); ++ if (backup_path == NULL) { ++ if (! (backup_path = talloc_asprintf (local, "%s.old", xapian_path))) { ++ ret = NOTMUCH_STATUS_OUT_OF_MEMORY; + goto DONE; + } ++ keep_backup = FALSE; ++ } ++ else ++ keep_backup = TRUE; ++ ++ if (stat (backup_path, &statbuf) != -1) { ++ fprintf (stderr, "Backup path already exists: %s\n", backup_path); ++ ret = NOTMUCH_STATUS_FILE_ERROR; ++ goto DONE; ++ } ++ if (errno != ENOENT) { ++ fprintf (stderr, "Unknown error while stat()ing backup path: %s\n", ++ strerror (errno)); ++ goto DONE; + } + + try { +@@ -924,14 +933,10 @@ notmuch_database_compact (const char *path, + goto DONE; + } + +- if (backup_path) { +- if (rename (xapian_path, backup_path)) { +- fprintf (stderr, "Error moving old database out of the way\n"); +- ret = NOTMUCH_STATUS_FILE_ERROR; +- goto DONE; +- } +- } else { +- rmtree (xapian_path); ++ if (rename (xapian_path, backup_path)) { ++ fprintf (stderr, "Error moving old database out of the way\n"); ++ ret = NOTMUCH_STATUS_FILE_ERROR; ++ goto DONE; + } + + if (rename (compact_xapian_path, xapian_path)) { +@@ -940,6 +945,9 @@ notmuch_database_compact (const char *path, + goto DONE; + } + ++ if (! keep_backup) ++ rmtree (backup_path); ++ + DONE: + if (notmuch) + notmuch_database_destroy (notmuch); +-- +1.8.3.1 + -- 2.26.2