From af614281fddc89ca67810bc27bca475adcc2ce6d Mon Sep 17 00:00:00 2001 From: David Bremner Date: Mon, 6 Oct 2014 08:04:30 +0200 Subject: [PATCH] Re: [PATCH 02/11] lib: Refactor _notmuch_database_link_message --- 0f/bba2135936ee51cd8df495cb59025569e6adee | 74 +++++++++++++++++++++++ 1 file changed, 74 insertions(+) create mode 100644 0f/bba2135936ee51cd8df495cb59025569e6adee diff --git a/0f/bba2135936ee51cd8df495cb59025569e6adee b/0f/bba2135936ee51cd8df495cb59025569e6adee new file mode 100644 index 000000000..eba657163 --- /dev/null +++ b/0f/bba2135936ee51cd8df495cb59025569e6adee @@ -0,0 +1,74 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id A0833431FBC + for ; Sun, 5 Oct 2014 23:04:43 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id cMnJRieRIst7 for ; + Sun, 5 Oct 2014 23:04:39 -0700 (PDT) +Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155]) + (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id EA6BD431FAE + for ; Sun, 5 Oct 2014 23:04:38 -0700 (PDT) +Received: from remotemail by yantan.tethera.net with local (Exim 4.80) + (envelope-from ) + id 1Xb1PQ-0004DC-Ng; Mon, 06 Oct 2014 03:04:36 -0300 +Received: (nullmailer pid 18042 invoked by uid 1000); Mon, 06 Oct 2014 + 06:04:30 -0000 +From: David Bremner +To: Austin Clements +Subject: Re: [PATCH 02/11] lib: Refactor _notmuch_database_link_message +In-Reply-To: <20141005232008.GB7970@csail.mit.edu> +References: <1412345958-8278-1-git-send-email-aclements@csail.mit.edu> + <1412345958-8278-3-git-send-email-aclements@csail.mit.edu> + <87k34fot7d.fsf@maritornes.cs.unb.ca> + <20141005232008.GB7970@csail.mit.edu> +User-Agent: Notmuch/0.18.1+98~gae27403 (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-pc-linux-gnu) +Date: Mon, 06 Oct 2014 08:04:30 +0200 +Message-ID: <871tqlpwcx.fsf@maritornes.cs.unb.ca> +MIME-Version: 1.0 +Content-Type: text/plain +Cc: notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Mon, 06 Oct 2014 06:04:43 -0000 + +Austin Clements writes: + +> Quoth David Bremner on Oct 05 at 9:45 am: +>> Austin Clements writes: +>> > + void *local = talloc_new (NULL); +>> +>> What's the advantage of using a local talloc context here? Is this just +>> an optimization? +> +> There are a few allocations that wind up going in to this local +> context because of the call to _consume_metadata_thread_id, so it's +> more convenient to free this one context on return from +> _notmuch_database_link_message than to worry about tracking these +> various allocations. + +OK, but wouldn't the lazy solution be to use message as a talloc +context? + +d -- 2.26.2