From ae4295eaa372125d837e6d27af1cc7d29ac2ce77 Mon Sep 17 00:00:00 2001 From: Tomi Ollila Date: Thu, 25 Sep 2014 22:54:53 +0300 Subject: [PATCH] Re: [PATCH 00/11] notmuch insert updates --- 06/fd92d10e8f6fb43e65980810beb654e8be8ced | 80 +++++++++++++++++++++++ 1 file changed, 80 insertions(+) create mode 100644 06/fd92d10e8f6fb43e65980810beb654e8be8ced diff --git a/06/fd92d10e8f6fb43e65980810beb654e8be8ced b/06/fd92d10e8f6fb43e65980810beb654e8be8ced new file mode 100644 index 000000000..65b83c0ea --- /dev/null +++ b/06/fd92d10e8f6fb43e65980810beb654e8be8ced @@ -0,0 +1,80 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 1C856431FB6 + for ; Thu, 25 Sep 2014 12:55:10 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id b-yoN5IqUFXg for ; + Thu, 25 Sep 2014 12:55:04 -0700 (PDT) +Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) + by olra.theworths.org (Postfix) with ESMTP id A9914431FAF + for ; Thu, 25 Sep 2014 12:55:04 -0700 (PDT) +Received: from guru.guru-group.fi (localhost [IPv6:::1]) + by guru.guru-group.fi (Postfix) with ESMTP id EF39D100033; + Thu, 25 Sep 2014 22:54:53 +0300 (EEST) +From: Tomi Ollila +To: David Bremner , Jani Nikula , + notmuch@notmuchmail.org +Subject: Re: [PATCH 00/11] notmuch insert updates +In-Reply-To: <878ul815jf.fsf@maritornes.cs.unb.ca> +References: + <878ul815jf.fsf@maritornes.cs.unb.ca> +User-Agent: Notmuch/0.18.1+97~g6c845ef (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-unknown-linux-gnu) +X-Face: HhBM'cA~ +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Thu, 25 Sep 2014 19:55:10 -0000 + +On Thu, Sep 25 2014, David Bremner wrote: + +> Jani Nikula writes: +> +>> This series refactors and cleans up insert, improves error handling and +>> reporting, and adds post-insert hook. I intend to add documentation and +>> more tests, but the code is ready for review. Also, at least some of the +>> cleanups and fixes in the beginning of the series could go in without +>> additional tests or documentation. +> +> The first 4 seem trivial, and I marked them so. +> +> 5-8 don't introduce new functionality, and don't break +> any existing tests. Subject to a little more review, these could +> probably be merged now. +> +> 5 is almost trivial; it wouldn't hurt to explicitly document the return +> values of sync_dir, while touching this code. +> +> 6 and 8 seem ok, but should probably have another pair of eyes. +> +> 7 seems ok. At first I worried about the usual issue of races between +> name definition and open, but it seems like nothing changes here. + +5-8 in this series LGTM. + +Tomi + -- 2.26.2