From adcf357f660248dad30cd82e499fbb02d0aca97a Mon Sep 17 00:00:00 2001 From: Felipe Contreras Date: Sun, 11 May 2014 17:27:34 +1900 Subject: [PATCH] RE: [PATCH 1/2] configure: add a fallback check for zlib --- 97/f7d8f0aeeecf0bc3f221501adf525702cab14b | 98 +++++++++++++++++++++++ 1 file changed, 98 insertions(+) create mode 100644 97/f7d8f0aeeecf0bc3f221501adf525702cab14b diff --git a/97/f7d8f0aeeecf0bc3f221501adf525702cab14b b/97/f7d8f0aeeecf0bc3f221501adf525702cab14b new file mode 100644 index 000000000..1189ccd99 --- /dev/null +++ b/97/f7d8f0aeeecf0bc3f221501adf525702cab14b @@ -0,0 +1,98 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id BA64D431FC0 + for ; Sat, 10 May 2014 15:27:45 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.799 +X-Spam-Level: +X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5 + tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, + FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id 8xGh55-2+ocx for ; + Sat, 10 May 2014 15:27:40 -0700 (PDT) +Received: from mail-ob0-f178.google.com (mail-ob0-f178.google.com + [209.85.214.178]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 4148B431FBF + for ; Sat, 10 May 2014 15:27:40 -0700 (PDT) +Received: by mail-ob0-f178.google.com with SMTP id va2so6574383obc.9 + for ; Sat, 10 May 2014 15:27:39 -0700 (PDT) +DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; + h=date:from:to:message-id:in-reply-to:references:subject:mime-version + :content-type:content-transfer-encoding; + bh=MXljUWpiN+6WTv9QQl7H7M3xDRUXlkk5rhJ67IzbrjE=; + b=qG8+DvleqtRs0XMMHvtwbyXo4p9wNdmxYw4tlNW2jLV6CHFS61Croc73WXnqCxskUO + TMVcm3wFI9sRzjggLgtrmNrCFotM4/vkz6l/674gDJj8lP7MCCFaTtFLZJPRLJNQ7MVF + zsr30FV9AN78SXEbXvXIsG6l5veVcSEyy0s0KX8emluFHd74YiBcluDGovUILDz5bbWE + c0ZgaBGbjOkyaxeKeY7pKZp3o6GxuLG4dLkdXcFZek6ytTPiBojM39y+GJkGF6VyDxjd + WThf+wm577nsYOnsaIoL/oYFh/com8RmYhbTtgTgHTy3D6S5eCPIKxtqbMpruBfjcVSp + 7lBg== +X-Received: by 10.182.33.6 with SMTP id n6mr23628418obi.48.1399760859753; + Sat, 10 May 2014 15:27:39 -0700 (PDT) +Received: from localhost (189-211-224-40.static.axtel.net. [189.211.224.40]) + by mx.google.com with ESMTPSA id + jy6sm11076309obc.25.2014.05.10.15.27.37 for + (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); + Sat, 10 May 2014 15:27:38 -0700 (PDT) +Date: Sat, 10 May 2014 17:27:34 -0500 +From: Felipe Contreras +To: Tomi Ollila , + Felipe Contreras , + =?UTF-8?B?WMSrY8Oy?= , notmuch@notmuchmail.org +Message-ID: <536ea7d6a4c86_3c5a8eb3048b@nysa.notmuch> +In-Reply-To: +References: <1399753646-3026-1-git-send-email-xico@atelo.org> + <536e965c9415e_300d7772fc9@nysa.notmuch> + +Subject: RE: [PATCH 1/2] configure: add a fallback check for zlib +Mime-Version: 1.0 +Content-Type: text/plain; + charset=utf-8 +Content-Transfer-Encoding: quoted-printable +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sat, 10 May 2014 22:27:45 -0000 + +Tomi Ollila wrote: +> On Sun, May 11 2014, Felipe Contreras wrot= +e: +> = + +> > X=C4=ABc=C3=B2 wrote: +> >> Since zlib is part of the base system, FreeBSD chose not to register= + it +> >> in pkg-config through zlib.pc. As a fallback test, configure will bu= +ild +> >> and run a zlib version check and make sure the header and library +> >> versions are compatible. +> > +> > We could try to generate our on zlib.pc, this way the configure scrip= +t +> > would be cleaner. +> = + +> But for that we'd need to figure out the version, and is there simpler +> robust way to do that some other way ? + +I don't meant to change the code that is checking for the version in the +patch, you use the same code, but instead of have_zlib.c gen_zlib_pc.c, +or something. + +-- = + +Felipe Contreras= -- 2.26.2