From acf653e84e6dba647d0f3f4ee9fd9480b1491712 Mon Sep 17 00:00:00 2001 From: Jani Nikula Date: Sun, 5 Jan 2014 00:53:25 +0200 Subject: [PATCH] Re: notmuch-0.16: realpath() compatibility issue; clang visibility problem --- 76/28693bd69c42aa0cf6d2ecf8af8322806de313 | 106 ++++++++++++++++++++++ 1 file changed, 106 insertions(+) create mode 100644 76/28693bd69c42aa0cf6d2ecf8af8322806de313 diff --git a/76/28693bd69c42aa0cf6d2ecf8af8322806de313 b/76/28693bd69c42aa0cf6d2ecf8af8322806de313 new file mode 100644 index 000000000..f7e169b54 --- /dev/null +++ b/76/28693bd69c42aa0cf6d2ecf8af8322806de313 @@ -0,0 +1,106 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 1DC55431FC0 + for ; Sat, 4 Jan 2014 14:53:35 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.699 +X-Spam-Level: +X-Spam-Status: No, score=-0.699 tagged_above=-999 required=5 + tests=[HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id VjpXVZTDX4hE for ; + Sat, 4 Jan 2014 14:53:27 -0800 (PST) +Received: from mail-ve0-f182.google.com (mail-ve0-f182.google.com + [209.85.128.182]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id E51D4431FBD + for ; Sat, 4 Jan 2014 14:53:26 -0800 (PST) +Received: by mail-ve0-f182.google.com with SMTP id jy13so8683093veb.13 + for ; Sat, 04 Jan 2014 14:53:26 -0800 (PST) +X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; + d=1e100.net; s=20130820; + h=x-gm-message-state:mime-version:in-reply-to:references:date + :message-id:subject:from:to:cc:content-type; + bh=8Xv9pJDuU2pgYNcoQzTvWNdVP30H9sS29wC380egCNk=; + b=NXeB9K7P8wo5pjMg+gTB7RYgICWTr0NqK26SaC/vszG8t0Ec/QmzdKXYfUuoL4ZGIk + aqEi0kxVbSlCu5KWwsBs3mFVFqwqgMxCvrSnn3uFg/EZMG2dBXS59nfCPfvKhP0Dw7hs + PSOa7meyPl2wM3J/zhgRm0cjjgz37ceJRPXxQQi0uSp3tVURbU8c1Uhv0uARrPB5v0wD + EV+z03KjVlURO7o+79q/5kp9hLLqY8v7zGEodR9XikI9Zvkj1zJ55usKyUjE5Bqs7mgH + +Z31ac37s2FQXLzhtpe8mDhLZaSK1Jb/LD5Muqj6UINRVkc26sFaXQp3U1aRZ1XBX8OS + Ia+g== +X-Gm-Message-State: + ALoCoQkJmPUObs4W/S9SF9IRP0WBu6OrWwwwY09Po/t47cYnZQ/avMOiYEsuuhSBOC+oheFwg6jH +MIME-Version: 1.0 +X-Received: by 10.58.57.194 with SMTP id k2mr17294685veq.0.1388876005180; Sat, + 04 Jan 2014 14:53:25 -0800 (PST) +Received: by 10.58.143.6 with HTTP; Sat, 4 Jan 2014 14:53:25 -0800 (PST) +Received: by 10.58.143.6 with HTTP; Sat, 4 Jan 2014 14:53:25 -0800 (PST) +In-Reply-To: <20140104223742.GC16514@danbala.tuwien.ac.at> +References: <20140103214735.GG27614@danbala.tuwien.ac.at> + + <871u0nnaw8.fsf@zancas.localnet> + <20140104223742.GC16514@danbala.tuwien.ac.at> +Date: Sun, 5 Jan 2014 00:53:25 +0200 +Message-ID: + +Subject: Re: notmuch-0.16: realpath() compatibility issue; + clang visibility problem +From: Jani Nikula +To: Thomas Klausner +Content-Type: multipart/alternative; boundary=001a11369b0eed1d6904ef2ce417 +Cc: Notmuch Mail +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sat, 04 Jan 2014 22:53:35 -0000 + +--001a11369b0eed1d6904ef2ce417 +Content-Type: text/plain; charset=UTF-8 + +On Jan 5, 2014 12:38 AM, "Thomas Klausner" wrote: +> +> On Sat, Jan 04, 2014 at 09:18:15AM -0400, David Bremner wrote: +> > I'm not sure what the right answer is here. MATHPATHLEN (and PATH_MAX) +> > are not necessarily defined; in particular this would break +> > compilation on GNU Hurd. Perhaps we should ship a compatibility +> > implementation of a POSIX.1-2008 compatible [1] realpath. Or maybe +> > realpath can be avoided completely here. +> +> A compatibility implementation for POSIX.1-2008-realpath would be +> great, as would be avoiding the call. Why is it necessary to resolve +> $HOME here? + +realpath is used to follow, not overwrite symlinks. + +--001a11369b0eed1d6904ef2ce417 +Content-Type: text/html; charset=UTF-8 + +


+On Jan 5, 2014 12:38 AM, "Thomas Klausner" <tk@giga.or.at> wrote:
+>
+> On Sat, Jan 04, 2014 at 09:18:15AM -0400, David Bremner wrote:
+> > I'm not sure what the right answer is here. MATHPATHLEN (and PATH_MAX)
+> > are not necessarily defined; in particular this would break
+> > compilation on GNU Hurd. Perhaps we should ship a compatibility
+> > implementation of a POSIX.1-2008 compatible [1] realpath. Or maybe
+> > realpath can be avoided completely here.
+>
+> A compatibility implementation for POSIX.1-2008-realpath would be
+> great, as would be avoiding the call. Why is it necessary to resolve
+> $HOME here?

+

realpath is used to follow, not overwrite symlinks.

+ +--001a11369b0eed1d6904ef2ce417-- -- 2.26.2