From ab1b708938eb90e11bec20b14d5a2e0696745707 Mon Sep 17 00:00:00 2001 From: David Bremner Date: Wed, 7 May 2014 22:17:58 +0900 Subject: [PATCH] Re: Linux-only fdatasync() in 3c13bc --- 5e/d5e4bf64bda262118fc2b1003bcbb23d85155b | 78 +++++++++++++++++++++++ 1 file changed, 78 insertions(+) create mode 100644 5e/d5e4bf64bda262118fc2b1003bcbb23d85155b diff --git a/5e/d5e4bf64bda262118fc2b1003bcbb23d85155b b/5e/d5e4bf64bda262118fc2b1003bcbb23d85155b new file mode 100644 index 000000000..f38dd86e9 --- /dev/null +++ b/5e/d5e4bf64bda262118fc2b1003bcbb23d85155b @@ -0,0 +1,78 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id A2600431FAE + for ; Wed, 7 May 2014 06:21:51 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id Y9mbIvy-ncWd for ; + Wed, 7 May 2014 06:21:44 -0700 (PDT) +Received: from mx.xen14.node3324.gplhost.com (gitolite.debian.net + [87.98.215.224]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 08655431FBD + for ; Wed, 7 May 2014 06:21:44 -0700 (PDT) +Received: from remotemail by mx.xen14.node3324.gplhost.com with local (Exim + 4.72) (envelope-from ) + id 1Wi1jt-0002sb-0l; Wed, 07 May 2014 13:18:25 +0000 +Received: (nullmailer pid 8176 invoked by uid 1000); Wed, 07 May 2014 + 13:17:58 -0000 +From: David Bremner +To: Tomi Ollila , Kushal Kumaran + , notmuch@notmuchmail.org +Subject: Re: Linux-only fdatasync() in 3c13bc +In-Reply-To: +References: <20140506195938.GA18213@coyotlan.Tlalpan> + <536a1723.0578e00a.601a.ffff976f@mx.google.com> + +User-Agent: Notmuch/0.18 (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-pc-linux-gnu) +Date: Wed, 07 May 2014 22:17:58 +0900 +Message-ID: <87vbthu3qx.fsf@maritornes.cs.unb.ca> +MIME-Version: 1.0 +Content-Type: text/plain; charset=utf-8 +Content-Transfer-Encoding: quoted-printable +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Wed, 07 May 2014 13:21:51 -0000 + +Tomi Ollila writes: + +> On Wed, May 07 2014, Kushal Kumaran wr= +ote: +> +>> X=C4=ABc=C3=B2 writes: +>> +>>> Also, commit 3c13bc introduced a call to fdatasync() which is not +>>> available on FreeBSD, and probably not either on MacOS at least. +>>> +>> +>> fdatasync is POSIX: +>> http://pubs.opengroup.org/onlinepubs/009695399/functions/fdatasync.html +> +> No wonder it is problematic, then >;) +> + +I seem to recall Austin saying on IRC that this usage was guaranteed to +call fsync anyway. Comments Austin? + +d + + -- 2.26.2