From aac1d7b88918f39b1b7c5bc0dcf831dcc9d5d8a8 Mon Sep 17 00:00:00 2001 From: Andreas Gruenbacher Date: Sat, 13 Mar 2010 18:17:04 +0100 Subject: [PATCH] fetch: Check for a "^{}" suffix with suffixcmp() Otherwise, we will check random bytes for ref names < 3 characters. Signed-off-by: Andreas Gruenbacher Signed-off-by: Junio C Hamano --- builtin-fetch.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/builtin-fetch.c b/builtin-fetch.c index b059d652c..0acf80991 100644 --- a/builtin-fetch.c +++ b/builtin-fetch.c @@ -588,7 +588,7 @@ static void find_non_local_tags(struct transport *transport, * to fetch then we can mark the ref entry in the list * as one to ignore by setting util to NULL. */ - if (!strcmp(ref->name + strlen(ref->name) - 3, "^{}")) { + if (!suffixcmp(ref->name, "^{}")) { if (item && !has_sha1_file(ref->old_sha1) && !will_fetch(head, ref->old_sha1) && !has_sha1_file(item->util) && -- 2.26.2