From a877365b4950567bc2325ff9beea8df638f02bec Mon Sep 17 00:00:00 2001 From: Tomi Ollila Date: Thu, 16 May 2013 15:01:10 +0300 Subject: [PATCH] Re: [PATCH] build: fix out-of-tree builds --- 40/217e0f4b6ffe0b598d24b9f49b4e6e6241bb34 | 92 +++++++++++++++++++++++ 1 file changed, 92 insertions(+) create mode 100644 40/217e0f4b6ffe0b598d24b9f49b4e6e6241bb34 diff --git a/40/217e0f4b6ffe0b598d24b9f49b4e6e6241bb34 b/40/217e0f4b6ffe0b598d24b9f49b4e6e6241bb34 new file mode 100644 index 000000000..9709861a8 --- /dev/null +++ b/40/217e0f4b6ffe0b598d24b9f49b4e6e6241bb34 @@ -0,0 +1,92 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 98619431FC3 + for ; Thu, 16 May 2013 05:01:19 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id L8Al97T2CiPT for ; + Thu, 16 May 2013 05:01:14 -0700 (PDT) +Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) + by olra.theworths.org (Postfix) with ESMTP id 68C68431FC2 + for ; Thu, 16 May 2013 05:01:14 -0700 (PDT) +Received: from guru.guru-group.fi (localhost [IPv6:::1]) + by guru.guru-group.fi (Postfix) with ESMTP id DFB07100094; + Thu, 16 May 2013 15:01:10 +0300 (EEST) +From: Tomi Ollila +To: David Bremner , Jani Nikula , + notmuch@notmuchmail.org +Subject: Re: [PATCH] build: fix out-of-tree builds +In-Reply-To: <87hai3dvkm.fsf@zancas.localnet> +References: <1368615519-25977-1-git-send-email-jani@nikula.org> + <87ehd8fdzg.fsf@zancas.localnet> <874ne49pcm.fsf@nikula.org> + <87hai3dvkm.fsf@zancas.localnet> +User-Agent: Notmuch/0.15.2+99~g7e455bc (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-unknown-linux-gnu) +X-Face: HhBM'cA~ +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Thu, 16 May 2013 12:01:19 -0000 + +On Thu, May 16 2013, David Bremner wrote: + +> Jani Nikula writes: +> +>> On Wed, 15 May 2013, David Bremner wrote: +>>> Jani Nikula writes: +>>>> # List all subdirectories here. Each contains its own Makefile.local +>>>> -subdirs := compat completion emacs lib man parse-time-string +>>>> -subdirs += performance-test util test +>>>> +subdirs = compat completion emacs lib man parse-time-string performance-test util test +>>> +>>> Is this a functional change or a cosmetic one? +>> +>> Functional. All of it seems to be required for out-of-tree builds (*) to +>> work. I'm afraid I've forgotten exactly why both := and += make it fail +>> (I wrote the patch a few months ago). +>> +> +> Still I guess it deserves a comment so we don't break it again? + +The following options could be tested (some day in (distant?) future): + +subdirs = compat completion emacs lib man parse-time-string +subdirs += performance-test util test + +or + +SUBDIRS := compat completion emacs lib man parse-time-string +SUBDIRS += performance-test util test +subdirs = $(SUBDIRS) + +but as Jani has already tested his version works just adding that +comment David asked is the least labor-intensive thing to do -- +and therefore IMHO the best thing to do for this case +(for sure I'm not going to spend more time on this now :D). + +> d + +Tomi -- 2.26.2