From a72f9373c01f9bbebd14af7cec6ff0de4c27c578 Mon Sep 17 00:00:00 2001 From: Junio C Hamano Date: Wed, 12 Jul 2006 23:00:46 -0700 Subject: [PATCH] git-repack: avoid redirecting stderr into git-pack-objects We are trying to catch error condition of git-rev-list and cause the downstream pack-objects to barf, but if you run rev-list with anything that mucks with its stderr (such as GIT_TRACE), any stderr output would cause the pipeline to fail. [jc: originally from Matthias Lederhofer, with a reworded error message.] Signed-off-by: Junio C Hamano --- git-repack.sh | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/git-repack.sh b/git-repack.sh index 640ad8d90..9da92fb06 100755 --- a/git-repack.sh +++ b/git-repack.sh @@ -43,7 +43,9 @@ case ",$all_into_one," in ;; esac pack_objects="$pack_objects $local $quiet $no_reuse_delta$extra" -name=$(git-rev-list --objects --all $rev_list 2>&1 | +name=$( { git-rev-list --objects --all $rev_list || + echo "git-rev-list died with exit code $?" + } | git-pack-objects --non-empty $pack_objects .tmp-pack) || exit 1 if [ -z "$name" ]; then -- 2.26.2