From a5968f7d9b1c17568fba27f7b7fd284b9431802d Mon Sep 17 00:00:00 2001 From: Zac Medico Date: Thu, 20 Oct 2011 07:16:50 -0700 Subject: [PATCH] misc-functions.sh: move sleep out of loop Having sleep in the world-writable loop causes riduculous delays for prefix users with exotic filesystem constraints (like a FAT filesystem mounted with umask=000). --- bin/misc-functions.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/bin/misc-functions.sh b/bin/misc-functions.sh index b3e62c5fe..0d2d20689 100755 --- a/bin/misc-functions.sh +++ b/bin/misc-functions.sh @@ -166,14 +166,14 @@ install_qa_check() { fi # Now we look for all world writable files. - local i + local i= for i in $(find "${D}/" -type f -perm -2); do vecho "QA Security Notice:" vecho "- ${i:${#D}:${#i}} will be a world writable file." vecho "- This may or may not be a security problem, most of the time it is one." vecho "- Please double check that $PF really needs a world writeable bit and file bugs accordingly." - sleep 1 done + [[ -n ${i} ]] && sleep 1 if type -P scanelf > /dev/null && ! has binchecks ${RESTRICT}; then local qa_var insecure_rpath=0 tmp_quiet=${PORTAGE_QUIET} -- 2.26.2