From a3ade2a77a2244a52352a8d0428f268b9b688b71 Mon Sep 17 00:00:00 2001 From: Tomi Ollila Date: Fri, 12 Feb 2016 19:14:36 +0200 Subject: [PATCH] Re: [PATCH v3] emacs: Report a lack of matches when calling `notmuch-show'. --- 34/3cd7c90b3424cbbb5dc717ee9f35edc5a34fbc | 74 +++++++++++++++++++++++ 1 file changed, 74 insertions(+) create mode 100644 34/3cd7c90b3424cbbb5dc717ee9f35edc5a34fbc diff --git a/34/3cd7c90b3424cbbb5dc717ee9f35edc5a34fbc b/34/3cd7c90b3424cbbb5dc717ee9f35edc5a34fbc new file mode 100644 index 000000000..3be5e9553 --- /dev/null +++ b/34/3cd7c90b3424cbbb5dc717ee9f35edc5a34fbc @@ -0,0 +1,74 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by arlo.cworth.org (Postfix) with ESMTP id 88FAA6DE0C51 + for ; Fri, 12 Feb 2016 09:14:26 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at cworth.org +X-Spam-Flag: NO +X-Spam-Score: 0.641 +X-Spam-Level: +X-Spam-Status: No, score=0.641 tagged_above=-999 required=5 tests=[AWL=-0.011, + SPF_NEUTRAL=0.652] autolearn=disabled +Received: from arlo.cworth.org ([127.0.0.1]) + by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id PbgdXcNGC5dL for ; + Fri, 12 Feb 2016 09:14:24 -0800 (PST) +Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) + by arlo.cworth.org (Postfix) with ESMTP id 30F6C6DE0A9A + for ; Fri, 12 Feb 2016 09:14:23 -0800 (PST) +Received: from guru.guru-group.fi (localhost [IPv6:::1]) + by guru.guru-group.fi (Postfix) with ESMTP id A725110007F; + Fri, 12 Feb 2016 19:14:36 +0200 (EET) +From: Tomi Ollila +To: David Edmondson , notmuch@notmuchmail.org +Subject: Re: [PATCH v3] emacs: Report a lack of matches when calling + `notmuch-show'. +In-Reply-To: <1455179607-16870-2-git-send-email-dme@dme.org> +References: <1455179607-16870-1-git-send-email-dme@dme.org> + <1455179607-16870-2-git-send-email-dme@dme.org> +User-Agent: Notmuch/0.21+32~g73439f8 (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-unknown-linux-gnu) +X-Face: HhBM'cA~ +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.20 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Fri, 12 Feb 2016 17:14:26 -0000 + +On Thu, Feb 11 2016, David Edmondson wrote: + +> If the basic query passed to `notmuch-show' generates no results, ring +> the bell and inform the user that no messages matched the query rather +> than displaying an empty buffer and showing an obscure error. + +Looks good (the parts I understood) and works fine (testing with +devel/try-emacs-mua). + +FYI: when testing with (eval-last-sexp) interactively (c-x c-e) +message does not appear in minibuffer -- since the following 'nil' +will take its place -- the msg is in *Messages* buffer + +Tomi + +> +> Similarly when refreshing a `notmuch-show' buffer and no messages match. +> --- +> emacs/notmuch-show.el | 144 +++++++++++++++++++++++++++++--------------------- +> emacs/notmuch.el | 6 ++- +> 2 files changed, 89 insertions(+), 61 deletions(-) +> -- 2.26.2